Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AdminBundle] collapse collection items #2523

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[AdminBundle] collapse collection items #2523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Kunstmaan/AdminBundle/Resources/public/css/style.css
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 8 additions & 1 deletion ...tmaan/AdminBundle/Resources/ui/scss/default-theme/components/structures/_nested-form.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@
}
}


.nested-form__item__collapsed {
box-shadow: inset 0px -13px 10px -10px #999;
}

/* Header
========================================================================== */
Expand Down Expand Up @@ -112,3 +114,8 @@
.nested-form__item__view {
padding: 1em;
}

.nested-form__item__collapsed .nested-form__item__view__collapsed {
height: 120px;
overflow-y: hidden;
}
9 changes: 7 additions & 2 deletions src/Kunstmaan/AdminBundle/Resources/views/Form/fields.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@

{# Items #}
{% for obj in form %}
<div id="{{ form.vars.id }}__{% if obj.vars.value.id is defined %}{{ obj.vars.value.id }}{% else %}{{ obj.vars.value }}{% endif %}-pp-container" class="js-nested-form__item nested-form__item{% if sortable %} js-sortable-item sortable-item{% endif %}"
<div id="{{ form.vars.id }}__{% if obj.vars.value.id is defined %}{{ obj.vars.value.id }}{% else %}{{ obj.vars.value }}{% endif %}-pp-container" class="js-nested-form__item nested-form__item{% if obj.children | length > 5 %} nested-form__item__collapsed{% endif %}{% if sortable %} js-sortable-item sortable-item{% endif %}"
{% if attr['nested_deletable'] is not defined or attr['nested_deletable'] != false %}
data-delete-key="{{ form.vars.id|replace({'form_': 'delete_'}) }}_{% if obj.vars.value.id is defined %}{{ obj.vars.value.id }}{% else %}{{ obj.vars.value }}{% endif %}"
{% endif %}
Expand All @@ -195,10 +195,15 @@
<i class="fa fa-chevron-down"></i>
</button>
{% endif %}
{% if obj.children | length > 5 %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to make this number configurable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually not sure how. I can add it to the configuration and then add it to parameters, but you can't inject a parameter into twig, unless its been made available globally.

<button type="button" class="js-move-up-pp-btn btn--raise-on-hover pp__actions__action pp__actions__action--up" title="{{ 'pagepart.buttons.expand'|trans }}" onclick="$(this).parent().parent().toggleClass('nested-form__item__collapsed');">
<i class="fa fa-expand"></i>
</button>
{% endif %}
</header>

{# View #}
<div class="js-nested-form__item__view nested-form__item__view">
<div class="js-nested-form__item__view nested-form__item__view nested-form__item__view__collapsed">
{% if obj.vars.compound %}
{{ form_widget(obj) }}
{% else %}
Expand Down
1 change: 1 addition & 0 deletions src/Kunstmaan/PagePartBundle/Resources/translations/messages.en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ pagepart:
edit: Edit
delete: Delete
resize: Minimize-Maximize
expand: Expand-Collapse

region:
button:
Expand Down
1 change: 1 addition & 0 deletions src/Kunstmaan/PagePartBundle/Resources/translations/messages.nl.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ pagepart:
edit: Bewerk
delete: Verwijder
resize: Minimaliseer / Maximaliseer
expand: Inklappen / Uitklappen
region:
button:
min: Minimaliseer
Expand Down