Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdminBundle] collapse collection items #2523

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JZuidema
Copy link
Contributor

@JZuidema JZuidema commented Jul 19, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

We ran into the problem that once you have a bunch of items in a collection type, while the item itself also has a lot of input fields, that you can't really find anything anymore. This merge requests automatically collapses items of a collection type if the item has more than 5 children.

For example:

Collection item has more than 5 children. Its automatically collapsed.
expand 1

There is a button at the right top to expand it.
expand 3

Button is clicked, and collection item is expanded to show all of its input fields
expand 2

@ProfessorKuma ProfessorKuma added this to the 5.4.0 milestone Jul 19, 2019
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • This PR seems to need a milestone of a minor release.

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat
Copy link
Member

acrobat commented Oct 18, 2019

@JZuidema I like the idea, maybe we should also add a expand button in the grey collapsed indicating zone. Small box in the middle of this zone with a caret down icon?

image

To make it more clear this zone can be expanded.

@@ -195,10 +195,15 @@
<i class="fa fa-chevron-down"></i>
</button>
{% endif %}
{% if obj.children | length > 5 %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to make this number configurable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually not sure how. I can add it to the configuration and then add it to parameters, but you can't inject a parameter into twig, unless its been made available globally.

@JZuidema
Copy link
Contributor Author

JZuidema commented Nov 1, 2019

@JZuidema I like the idea, maybe we should also add a expand button in the grey collapsed indicating zone. Small box in the middle of this zone with a caret down icon?

image

To make it more clear this zone can be expanded.

Okay well, I've looked into this but frontend is not really my area of expertise. Do you think one of you guys could look into it?

@acrobat acrobat modified the milestones: 5.4.0, 5.5.0 Jan 9, 2020
@acrobat acrobat removed this from the 5.5.0 milestone Mar 17, 2020
@acrobat
Copy link
Member

acrobat commented Oct 30, 2020

@dbeerten @FVKVN can anyone check the frontend comments and see if we can improve those?

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • This PR seems to need a milestone of a minor release.

@ProfessorKuma ProfessorKuma added this to the 5.8.0 milestone Oct 30, 2020
@acrobat acrobat modified the milestones: 5.8.0, 5.9.0 Mar 17, 2021
@acrobat acrobat modified the milestones: 5.9.0, 5.10.0 Oct 10, 2021
@acrobat
Copy link
Member

acrobat commented Oct 12, 2021

This still needs some FE work to improve the look of this feature. I'm removing the milestone so we finish this somewhere in 6.x

@acrobat acrobat removed this from the 5.10.0 milestone Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants