Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed allprojects block from root build script #436

Merged
merged 4 commits into from
May 29, 2024

Conversation

dkrasnoff
Copy link

@dkrasnoff dkrasnoff commented May 10, 2024

Gradle docs says that we should avoid allprojects and subprojects blocks.
In this PR I made next steps:

  • Moved common logic from allprojects block in the root build script to common-conventions.gradle.kts
  • Moved multiplatform connected logic from allprojects block in the root build script to multiplatform-conventions.gradle.kts
  • Rewrote to kotlin dsl build script in atomicfu-gradle-plugin

Depends on

@dkrasnoff dkrasnoff requested a review from adam-enko May 10, 2024 15:36
@dkrasnoff dkrasnoff force-pushed the build-config/removed-allprojects branch from f2e94ad to 44b391d Compare May 13, 2024 08:15
@dkrasnoff dkrasnoff force-pushed the build-config/publishing-convention-plugin branch 2 times, most recently from 2df1841 to 86c5e8f Compare May 15, 2024 13:19
@dkrasnoff dkrasnoff force-pushed the build-config/removed-allprojects branch from 44b391d to e8d0e13 Compare May 15, 2024 13:37
@dkrasnoff dkrasnoff force-pushed the build-config/publishing-convention-plugin branch 2 times, most recently from 6669ffd to e0231d8 Compare May 16, 2024 12:22
@dkrasnoff dkrasnoff force-pushed the build-config/removed-allprojects branch from e8d0e13 to 9bd38fa Compare May 17, 2024 07:49
@dkrasnoff
Copy link
Author

dkrasnoff commented May 22, 2024

Depends on #435 and #434

@dkrasnoff dkrasnoff force-pushed the build-config/publishing-convention-plugin branch from c0d006e to 6c18a52 Compare May 24, 2024 18:49
@dkrasnoff dkrasnoff force-pushed the build-config/removed-allprojects branch from 9bd38fa to e55af61 Compare May 28, 2024 11:32
@dkrasnoff dkrasnoff requested a review from adam-enko May 28, 2024 11:39
@dkrasnoff dkrasnoff force-pushed the build-config/publishing-convention-plugin branch from 7193a87 to 146e6d9 Compare May 28, 2024 14:13
@dkrasnoff dkrasnoff force-pushed the build-config/removed-allprojects branch from e55af61 to 7d57f58 Compare May 28, 2024 14:35
@dkrasnoff dkrasnoff changed the base branch from build-config/publishing-convention-plugin to develop May 28, 2024 15:48
@dkrasnoff dkrasnoff force-pushed the build-config/removed-allprojects branch from 7d57f58 to 8c7d48e Compare May 28, 2024 15:59
@adam-enko adam-enko self-requested a review May 28, 2024 16:15
Copy link

@adam-enko adam-enko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

Copy link

@adam-enko adam-enko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I meant to approve before, but I guess I missed the approve button)

A small note: compile-options-conventions.gradle.kts should be converted to a kotlin-base-conventions..gradle.kts and applied in the kotlin-jvm and kotlin-multiplatform conventions. But that can be done in a later PR - I'll leave it up to you.

@dkrasnoff dkrasnoff merged commit 87a7cd7 into develop May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants