-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed allprojects block from root build script #436
Conversation
f2e94ad
to
44b391d
Compare
2df1841
to
86c5e8f
Compare
44b391d
to
e8d0e13
Compare
6669ffd
to
e0231d8
Compare
e8d0e13
to
9bd38fa
Compare
c0d006e
to
6c18a52
Compare
9bd38fa
to
e55af61
Compare
7193a87
to
146e6d9
Compare
e55af61
to
7d57f58
Compare
….kts` convention plugin
7d57f58
to
8c7d48e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I meant to approve before, but I guess I missed the approve button)
A small note: compile-options-conventions.gradle.kts
should be converted to a kotlin-base-conventions..gradle.kts
and applied in the kotlin-jvm
and kotlin-multiplatform
conventions. But that can be done in a later PR - I'll leave it up to you.
Gradle docs says that we should avoid allprojects and subprojects blocks.
In this PR I made next steps:
allprojects
block in the root build script tocommon-conventions.gradle.kts
allprojects
block in the root build script tomultiplatform-conventions.gradle.kts
atomicfu-gradle-plugin
Depends on