-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved publishing.gradle to convention plugin #435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkrasnoff
force-pushed
the
build-config/publishing-convention-plugin
branch
from
May 10, 2024 15:26
f901ac2
to
543b846
Compare
adam-enko
requested changes
May 13, 2024
buildSrc/src/main/kotlin/non-multiplatform.publish-conventions.gradle.kts
Outdated
Show resolved
Hide resolved
buildSrc/src/main/kotlin/non-multiplatform.publish-conventions.gradle.kts
Outdated
Show resolved
Hide resolved
dkrasnoff
force-pushed
the
build-config/publishing-convention-plugin
branch
from
May 13, 2024 08:53
543b846
to
2df1841
Compare
dkrasnoff
force-pushed
the
build-config/compile-options-convention-plugin
branch
from
May 13, 2024 12:38
f4b8012
to
2228f59
Compare
dkrasnoff
force-pushed
the
build-config/publishing-convention-plugin
branch
from
May 15, 2024 13:19
2df1841
to
86c5e8f
Compare
dkrasnoff
commented
May 15, 2024
buildSrc/src/main/kotlin/non-multiplatform.publish-conventions.gradle.kts
Outdated
Show resolved
Hide resolved
dkrasnoff
force-pushed
the
build-config/publishing-convention-plugin
branch
2 times, most recently
from
May 16, 2024 12:22
6669ffd
to
e0231d8
Compare
Depends on #434 |
adam-enko
requested changes
May 22, 2024
buildSrc/src/main/kotlin/non-multiplatform.publish-conventions.gradle.kts
Outdated
Show resolved
Hide resolved
adam-enko
reviewed
May 22, 2024
adam-enko
reviewed
May 22, 2024
buildSrc/src/main/kotlin/non-multiplatform.publish-conventions.gradle.kts
Outdated
Show resolved
Hide resolved
adam-enko
reviewed
May 22, 2024
buildSrc/src/main/kotlin/non-multiplatform.publish-conventions.gradle.kts
Outdated
Show resolved
Hide resolved
adam-enko
reviewed
May 22, 2024
adam-enko
reviewed
May 22, 2024
@adam-enko, CI say we can not get rid of:
|
dkrasnoff
force-pushed
the
build-config/publishing-convention-plugin
branch
2 times, most recently
from
May 24, 2024 18:49
c0d006e
to
6c18a52
Compare
D'oh! Oh well, better revert it. Thanks for trying! |
mvicsokolova
approved these changes
May 28, 2024
dkrasnoff
changed the base branch from
build-config/compile-options-convention-plugin
to
master
May 28, 2024 13:58
dkrasnoff
force-pushed
the
build-config/publishing-convention-plugin
branch
from
May 28, 2024 14:13
7193a87
to
146e6d9
Compare
adam-enko
reviewed
May 28, 2024
adam-enko
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Divided
publishing.gradle
into two convention plugins:non-multiplatform.publish-conventions.gradle.kts
andpublish-conventions.gradle.kts
Depends on