Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved publishing.gradle to convention plugin #435

Merged
merged 1 commit into from
May 28, 2024

Conversation

dkrasnoff
Copy link

@dkrasnoff dkrasnoff commented May 10, 2024

Divided publishing.gradle into two convention plugins: non-multiplatform.publish-conventions.gradle.kts and publish-conventions.gradle.kts

Depends on

@dkrasnoff dkrasnoff requested a review from adam-enko May 10, 2024 15:25
@dkrasnoff dkrasnoff force-pushed the build-config/publishing-convention-plugin branch from f901ac2 to 543b846 Compare May 10, 2024 15:26
@dkrasnoff dkrasnoff force-pushed the build-config/publishing-convention-plugin branch from 543b846 to 2df1841 Compare May 13, 2024 08:53
@dkrasnoff dkrasnoff force-pushed the build-config/compile-options-convention-plugin branch from f4b8012 to 2228f59 Compare May 13, 2024 12:38
@dkrasnoff dkrasnoff force-pushed the build-config/publishing-convention-plugin branch from 2df1841 to 86c5e8f Compare May 15, 2024 13:19
@dkrasnoff dkrasnoff force-pushed the build-config/publishing-convention-plugin branch 2 times, most recently from 6669ffd to e0231d8 Compare May 16, 2024 12:22
@dkrasnoff dkrasnoff requested a review from adam-enko May 16, 2024 13:11
@dkrasnoff
Copy link
Author

Depends on #434

@dkrasnoff
Copy link
Author

dkrasnoff commented May 24, 2024

@adam-enko, CI say we can not get rid of:

   // NOTE: This is a temporary WA, see KT-61313.
    tasks.withType<Sign>().configureEach sign@{
        val pubName = name.substringAfter("sign").substringBefore("Publication")

        // Task ':linkDebugTest<platform>' uses this output of task ':sign<platform>Publication' without declaring an explicit or implicit dependency
        tasks.findByName("linkDebugTest$pubName")?.let { linkTask ->
            linkTask.mustRunAfter(this@sign)
        }
        // Task ':compileTestKotlin<platform>' uses this output of task ':sign<platform>Publication' without declaring an explicit or implicit dependency
        tasks.findByName("compileTestKotlin$pubName")?.let { compileTask ->
            compileTask.mustRunAfter(this@sign)
        }
    }

https://teamcity.jetbrains.com/buildConfiguration/KotlinTools_KotlinxAtomicfu_BuildAggregatedLinuxWindows/4627137?hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildProblemsSection=true&expandBuildChangesSection=true&expandBuildDeploymentsSection=false

@dkrasnoff dkrasnoff force-pushed the build-config/publishing-convention-plugin branch 2 times, most recently from c0d006e to 6c18a52 Compare May 24, 2024 18:49
@adam-enko
Copy link

@adam-enko, CI say we can not get rid of:

   // NOTE: This is a temporary WA, see KT-61313.
    tasks.withType<Sign>().configureEach sign@{

D'oh! Oh well, better revert it. Thanks for trying!

@dkrasnoff dkrasnoff changed the base branch from build-config/compile-options-convention-plugin to master May 28, 2024 13:58
@dkrasnoff dkrasnoff changed the base branch from master to develop May 28, 2024 13:58
@dkrasnoff dkrasnoff force-pushed the build-config/publishing-convention-plugin branch from 7193a87 to 146e6d9 Compare May 28, 2024 14:13
Copy link

@adam-enko adam-enko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress!

@dkrasnoff dkrasnoff merged commit 01915e3 into develop May 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants