New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACHIEVEMENT] The label maker achievemt #38
Changes from 4 commits
12c5d1b
25fec0d
66c9165
346df0c
21f0980
1bcce5d
fe4eb5a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
var labelBabyJunior = { | ||
name: 'Label Baby Junior', | ||
check: function(pullRequest, shall) { | ||
if (isManyLabels(pullRequest)) { | ||
var achievement = { | ||
avatar : 'images/achievements/theLabelMaker.achievment.jpg', | ||
name: 'The Label Maker', | ||
short: 'Is this a label maker?', | ||
description: 'You\'ve put many labels, thank you for organizng. You\'re a gift that keeps on re-giving' , | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. typo in the word |
||
relatedPullRequest: pullRequest._id | ||
}; | ||
|
||
shall.grant(pullRequest.creator.username, achievement); | ||
} | ||
} | ||
}; | ||
|
||
function isManyLabels(pullRequest) { | ||
var labels = pullRequest.labels; | ||
return labels && labels.length > 3; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that 4 labels as a minimum is a bit low. Take a look at this PR from AngularJS (Google's Javascript framework) - it has 8(!) labels. They have tons of PRs with 4-5 labels. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree. 3 is actually just the go to num I use to test multiple stuff. |
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. missing a please check that your code is running before you There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It worked until you made me change it =P There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I did noto made you change it, I suggested... :-) |
||
module.exports = labelBabyJunior; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please add one empty line at the end of the file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in the word
achievement
- image does not load