Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACHIEVEMENT] The label maker achievemt #38

Merged
merged 7 commits into from Jan 27, 2017
Merged

[ACHIEVEMENT] The label maker achievemt #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
12c5d1b
The label maker achievemt
dunaevsky Jan 26, 2017
25fec0d
label maker - removed notes
dunaevsky Jan 26, 2017
66c9165
fix 2
dunaevsky Jan 26, 2017
346df0c
label maker ach - update 3
dunaevsky Jan 26, 2017
21f0980
label maker - update 4
dunaevsky Jan 27, 2017
1bcce5d
label maker typo fixes+image rescale
dunaevsky Jan 27, 2017
fe4eb5a
label maker image ratio fix+name fix
dunaevsky Jan 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 23 additions & 0 deletions achievements/labelBabyJunior.achievement.js
View file
Open in desktop
@@ -0,0 +1,23 @@
var labelBabyJunior = {
name: 'Label Baby Junior',
check: function(pullRequest, shall) {
if (isManyLabels(pullRequest)) {
var achievement = {
avatar : 'images/achievements/theLabelMaker.achievement.jpg',
name: 'The Label Maker',
short: 'Is this a label maker?',
description: 'You\'ve put many labels, thank you for organizing. You\'re a gift that keeps on re-giving' ,
relatedPullRequest: pullRequest._id
};

shall.grant(pullRequest.creator.username, achievement);
}
}
};

function isManyLabels(pullRequest) {
var labels = pullRequest.labels;
return labels && labels.length > 5;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a new line separation between the end of the function to the module.exports...


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a }

please check that your code is running before you push to Github :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked until you made me change it =P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did noto made you change it, I suggested... :-)

module.exports = labelBabyJunior;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add one empty line at the end of the file.
see this answer

Binary file added public/images/achievements/labelBabyJunior.achievement.jpg
View file
Open in desktop
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.