Github Actions: Provide matrix for upload_coverage job #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
jeremywiebe
commented
May 16, 2024
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest] | ||
| node-version: [20.x] |
There was a problem hiding this comment.
Note that on line 210 below, we reference matrix.node-version but until this PR that didn't exist. According to Github's docs, it will use an empty string if a matrix value is missing. Which would explain the missing value in the cache keys.... I hope.
|
Size Change: 0 B Total Size: 839 kB ℹ️ View Unchanged
|
mark-fitzgerald
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While investigating a problem where the Github Action cache is broken (we get type check failures in the action runs that don't occur locally), I noticed that some cache keys were missing the node version in them (see screenshot).
I think I've traced it down to a missing
strategykey in one of the jobs that uses our sharedshared-node-cacheaction.Issue: "none"
Test plan:
There's no way to test this until it's landed.
Once it's landed, I'll clear the caches once more and then monitor as PRs check/set the cache. Hopefully we won't see any more cache keys that are missing a node version (ie. ones that start with
Linux--v1-...(note the double dash, the node version should be between those dashes!)