Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Github Actions: Provide matrix for upload_coverage job (#1288)
## Summary: While investigating a problem where the Github Action cache is broken (we get type check failures in the action runs that don't occur locally), I noticed that some cache keys were missing the node version in them (see screenshot). <img width="222" alt="image" src="https://github.com/Khan/perseus/assets/77138/8dc154e0-ca69-42ce-ad1f-c59aa72d9e42"> I think I've traced it down to a missing `strategy` key in one of the jobs that uses our shared `shared-node-cache` action. Issue: "none" ## Test plan: There's no way to test this until it's landed. Once it's landed, I'll clear the caches once more and then monitor as PRs check/set the cache. Hopefully we won't see any more cache keys that are missing a node version (ie. ones that start with `Linux--v1-...` (note the double dash, the node version should be between those dashes!) Author: jeremywiebe Reviewers: jeremywiebe, mark-fitzgerald Required Reviewers: Approved By: mark-fitzgerald Checks: ✅ Upload Coverage (ubuntu-latest, 20.x), ⏭️ Publish npm snapshot, ✅ Cypress (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), 🚫 Upload Coverage, ✅ gerald, ✅ gerald, ⏭️ Publish npm snapshot, 🚫 Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), 🚫 Cypress (ubuntu-latest, 20.x), 🚫 Jest Coverage (ubuntu-latest, 20.x), 🚫 Check builds for changes in size (ubuntu-latest, 20.x), 🚫 Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1288
- Loading branch information