Skip to content

Commit

Permalink
Github Actions: Provide matrix for upload_coverage job (#1288)
Browse files Browse the repository at this point in the history
## Summary:

While investigating a problem where the Github Action cache is broken (we get type check failures in the action runs that don't occur locally), I noticed that some cache keys were missing the node version in them (see screenshot). 

<img width="222" alt="image" src="https://github.com/Khan/perseus/assets/77138/8dc154e0-ca69-42ce-ad1f-c59aa72d9e42">

I think I've traced it down to a missing `strategy` key in one of the jobs that uses our shared `shared-node-cache` action. 

Issue: "none"

## Test plan:

There's no way to test this until it's landed. 

Once it's landed, I'll clear the caches once more and then monitor as PRs check/set the cache. Hopefully we won't see any more cache keys that are missing a node version (ie. ones that start with `Linux--v1-...` (note the double dash, the node version should be between those dashes!)

Author: jeremywiebe

Reviewers: jeremywiebe, mark-fitzgerald

Required Reviewers:

Approved By: mark-fitzgerald

Checks: ✅ Upload Coverage (ubuntu-latest, 20.x), ⏭️  Publish npm snapshot, ✅ Cypress (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), 🚫 Upload Coverage, ✅ gerald, ✅ gerald, ⏭️  Publish npm snapshot, 🚫 Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), 🚫 Cypress (ubuntu-latest, 20.x), 🚫 Jest Coverage (ubuntu-latest, 20.x), 🚫 Check builds for changes in size (ubuntu-latest, 20.x), 🚫 Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ gerald

Pull Request URL: #1288
  • Loading branch information
jeremywiebe committed May 16, 2024
1 parent 8534a9f commit 58d2a52
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .github/workflows/node-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,11 @@ jobs:

upload_coverage:
name: Upload Coverage
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest]
node-version: [20.x]
needs: [cypress, coverage]
steps:
- uses: actions/checkout@v4
Expand Down

0 comments on commit 58d2a52

Please sign in to comment.