Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #37217 Install package tab & FQDN setting #10987

Merged
merged 1 commit into from
May 20, 2024

Conversation

stejskalleos
Copy link
Contributor

Use host.display_name instead of host.hostname

What are the changes introduced in this pull request?

Follow up to #10913

Considerations taken when implementing this change?

@Dyrkon is out of the office, so I'm taking his PR.

What are the testing steps for this pull request?

  • Change the Display FQDN for hosts setting to No
  • Go to the host detail
  • On the packages tab click Install packages
  • Verify that host is displayed without domain

Use host.display_name instead of host.hostname
@stejskalleos
Copy link
Contributor Author

@jeremylenz and it's all 🍏

@stejskalleos
Copy link
Contributor Author

@jeremylenz I was wrong; the CI / Ruby / test:katello - Foreman develop with Ruby 3.0 failed, but I don't see how it relates to my UI changes.

@jeremylenz
Copy link
Member

Sometimes it just times out I think? retrying

@stejskalleos
Copy link
Contributor Author

Ruby 3.0 and Node 18 on PostgreSQL 13 Failed again
@jeremylenz not sure if it is caused by my changes TBH

@jeremylenz
Copy link
Member

There are no Ruby changes here so I'm pretty sure the failure is unrelated. If it doesn't pass this time I'm just gonna ignore it..

@stejskalleos
Copy link
Contributor Author

@jeremylenz can we get this in?

@jeremylenz jeremylenz merged commit 1494c01 into Katello:master May 20, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants