Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #37217 - Missing related changes on install package page when di… #10913

Closed
wants to merge 1 commit into from
Closed

Refs #37217 - Missing related changes on install package page when di… #10913

wants to merge 1 commit into from

Conversation

Dyrkon
Copy link
Contributor

@Dyrkon Dyrkon commented Feb 29, 2024

Followup of 10538.

@theforeman-bot
Copy link

Can one of the admins verify this patch?

@stejskalleos
Copy link
Contributor

@Dyrkon can you please rebase over the latest master?

@jeremylenz could you please do the review?

@jeremylenz
Copy link
Member

[test katello]

jeremylenz
jeremylenz approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as advertised.

CI failures are probably unrelated, but I'll wait for the rebase & green tests to be safe

Thanks @Dyrkon!

@jeremylenz
Copy link
Member

It seems I can't re-run the tests, so this will definitely need a rebase.

@amolpati30
Copy link

Ack, I've tested and it works

amolpati30
amolpati30 approved these changes Apr 8, 2024
View reviewed changes
Copy link

@amolpati30 amolpati30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working as expected in upstream.

@stejskalleos
Copy link
Contributor

@Dyrkon can you rebase please, so we can have green CI?

@Dyrkon Dyrkon force-pushed the mm/display_fqdn_install_packages branch from c9e3e82 to 49ed8b7 Compare April 9, 2024 19:53
@jeremylenz
Copy link
Member

Looks like the React test failures are legit now 😄

you can use DEBUG=nock.* npx jest <filename> to debug the nock stuff. let me know if you need help

@jeremylenz
Copy link
Member

@Dyrkon any updates here?

@Dyrkon Dyrkon force-pushed the mm/display_fqdn_install_packages branch from 49ed8b7 to a2ea5fa Compare May 2, 2024 11:57
@Dyrkon
Copy link
Contributor Author

Dyrkon commented May 3, 2024

@jeremylenz I have rebased the branch, but there are 8 tests that are failing. I have finals in the next couple of weeks, so I won't have the time to address them for a while.

@stejskalleos stejskalleos mentioned this pull request May 7, 2024
Merged
@stejskalleos
Copy link
Contributor

@jeremylenz @Dyrkon Follow up PR with fixed code: https://github.com/Katello/katello/pull/10987/files

@jeremylenz
Copy link
Member

Closing in favor of #10987 which is already merged.

@jeremylenz jeremylenz closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremylenz jeremylenz jeremylenz approved these changes

@amolpati30 amolpati30 amolpati30 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@Dyrkon @theforeman-bot @stejskalleos @jeremylenz @amolpati30