Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coherent return types for Kruskal and Prim #172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aurorarossi
Copy link
Member

@aurorarossi aurorarossi commented Sep 12, 2022

Now both algorithms return a Vector{Edges}. I chose Vector{Edges} instead of Vector{SimpleWeightedEdge} because in this way the code is faster. In the case that weights are needed it is easy to query them.
Issue #130

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #172 (c5b378f) into master (a3fb98b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #172   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         109      109           
  Lines        6314     6314           
=======================================
  Hits         6159     6159           
  Misses        155      155           

@aurorarossi
Copy link
Member Author

@matbesancon

@simonschoelly
Copy link
Contributor

Hey Aurora, thanks for your PR.

While it might be a very good idea, to return the same types from both algorithms, changing that now would break existing code, so we rather do this when we bump the mayor version to v2.0.

@aurorarossi
Copy link
Member Author

Ok thanks @simonschoelly !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge this PR (yet)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coherent return types for Kruskal vs Prim
3 participants