This repository has been archived by the owner on Mar 26, 2024. It is now read-only.
PRJ-57 Draw notifications and floating toolbar on top of client markdown/JCEF component #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARTI1208
force-pushed
the
prj-57
branch
2 times, most recently
from
36fa067
to
d6b7158
Compare
ARTI1208
commented
Mar 23, 2022
| backgroundColor = component.background, // from Graphics2D "Default Rendering Attributes" java doc | ||
| paint = component.foreground, // from Graphics2D "Default Rendering Attributes" java doc | ||
| foregroundColor = component.foreground, // from Graphics2D "Default Rendering Attributes" java doc | ||
| font = component.font, | ||
| device = component.graphicsConfiguration.device | ||
| device = component.graphicsConfiguration?.device ?: GraphicsEnvironment.getLocalGraphicsEnvironment().defaultScreenDevice |
There was a problem hiding this comment.
If I remeber well component.graphicsConfiguration will be null for fake windows. Wanted to recheck today but due to disk problems didn't
SerVB
reviewed
Mar 29, 2022
There was a problem hiding this comment.
With https://youtrack.jetbrains.com/issue/PRJ-700 solved, changing of clearRect could be unneeded. Otherwise, LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client changes: JetBrains/projector-client#141