This repository has been archived by the owner on Mar 26, 2024. It is now read-only.
PRJ-57 Draw notifications and floating toolbar on top of client markdown/JCEF component #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerVB
reviewed
Mar 29, 2022
Comment on lines
+53
to
+54
| // clear canvas so that semi-transparent parts won't stack on top of each other | ||
| clearRect(0.0, 0.0, buffer.width.toDouble(), buffer.height.toDouble()) |
There was a problem hiding this comment.
In the future, probably it could be easier to just set https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/globalCompositeOperation to copy. However, firstly https://youtrack.jetbrains.com/issue/PRJ-700 should be resolved
| @@ -95,7 +95,7 @@ internal class DomContext2d(private val myContext2d: CanvasRenderingContext2D) : | |||
| CompositeOperationType.CLEAR, | |||
| CompositeOperationType.DST, | |||
| -> "source-over".also { | |||
| logger.info { "Missing implementation for $this, applying source-over" } | |||
| logger.info { "Missing implementation for $type, applying $it" } | |||
Comment on lines
+117
to
+146
| MouseEventInit( | ||
| screenX = screenX, | ||
| screenY = screenY, | ||
| clientX = clientX + iFrame.offsetLeft, | ||
| clientY = clientY + iFrame.offsetTop, | ||
| button = button, | ||
| buttons = buttons, | ||
| relatedTarget = relatedTarget, | ||
| region = region, | ||
| ctrlKey = ctrlKey, | ||
| shiftKey = shiftKey, | ||
| altKey = altKey, | ||
| metaKey = metaKey, | ||
| modifierAltGraph = getModifierState("AltGraph"), | ||
| modifierCapsLock = getModifierState("CapsLock"), | ||
| modifierFn = getModifierState("Fn"), | ||
| modifierFnLock = getModifierState("FnLock"), | ||
| modifierHyper = getModifierState("Hyper"), | ||
| modifierNumLock = getModifierState("NumLock"), | ||
| modifierScrollLock = getModifierState("ScrollLock"), | ||
| modifierSuper = getModifierState("Super"), | ||
| modifierSymbol = getModifierState("Symbol"), | ||
| modifierSymbolLock = getModifierState("SymbolLock"), | ||
| view = view, | ||
| detail = detail, | ||
| bubbles = bubbles, | ||
| cancelable = cancelable, | ||
| composed = composed, | ||
| ) | ||
| } |
There was a problem hiding this comment.
That's because of copying object from a different context to make it usable? Let's leave a comment about it!
Comment on lines
+50
to
+51
| iFrame.addEventListener("load", EventListener { | ||
| setOpenLinksInExternalBrowser(openLinksInExternalBrowser, true) |
Comment on lines
+43
to
+44
| @SerialName("d") | ||
| FAKE_WINDOW, |
There was a problem hiding this comment.
It's unclear what's a "fake window". From the other repo, I see it's when it doesn't extend Window, but just heavy-weight component. Let's add a comment at least, or also rename to something like NON_WINDOW_HW_COMPONENT
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server changes: JetBrains/projector-server#121