Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NDI-matlab functionality: reading from ndi.element.timeseries objects, writing ndi.neuron objects #157

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

stevevanhooser
Copy link

These modifications allow:

  1. JRCLUST to read ndi.element.timeseries objects (including ndi.probe.timeseries objects) directly from NDI-matlab
  2. There is a bootstrap method to create the parameter file.
  3. There is an jrclust.detect.ndiRecording object to read the data in.
  4. There is an jrclust.export.ndi method to save the clustered neurons back to NDI-matlab.
  5. The bootstrap functionality is documented in the .rst documentation file.

Requires http://github.com/VH-Lab/NDI-matlab for these functions (error is given if not installed)

Still needed:

There appears to be no documentation for the export methods (or, I didn't find it). I would like to add documentation to the export ndi function in the documentation.

@aliddell
Copy link
Collaborator

You're right about the export documentation, there's not much (or none) to speak of. I can work on standing that up. Can I ask that you add a few unit tests? I'm happy to talk offline about the test framework I've set up.

@stevevanhooser
Copy link
Author

Hi Alan -

Yes, I'd be delighted to add unit tests. Can you point me to an example, maybe an Intan example, or any other example that you think would be useful?

-Steve

@aliddell
Copy link
Collaborator

Unit tests are another thing I'm still building out -- in particular there aren't any reading or import/export tests (you probably saw this already). I think at a bare minimum, if you can write something out with NDI and read it back in with JRCLUST, and everything is where you expect it to be, that would be useful. We can talk about edge cases when we meet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants