Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated fixes #2312

Open
wants to merge 5 commits into
base: v0.7.0
Choose a base branch
from
Open

Conversation

skinkie
Copy link

@skinkie skinkie commented Jul 25, 2022

One annoying complition error, and some deprecation warnings.

@aothms
Copy link
Member

aothms commented Jul 25, 2022

Thanks.

HCompCurve is still used on OCCT versions under 7.6, which is still the default on e.g most linux distros. So for the code to remain compatible the deleted include also needs to be conditional wrt OCCT version.

https://github.com/IfcOpenShell/IfcOpenShell/blob/v0.7.0/src/ifcgeom/IfcTrimmedCurve.cpp#L58

See CI Failure:

https://github.com/IfcOpenShell/IfcOpenShell/runs/7495267968?check_suite_focus=true#step:5:660

@skinkie
Copy link
Author

skinkie commented Jul 25, 2022

@aothms how are these things checked within QA?

@aothms
Copy link
Member

aothms commented Jul 25, 2022

We just have some CI scripts in github actions. Currently they compile against 7.5 as that's what the distros provide and compiling occt in the github action would be prohibitive in terms of runtime https://github.com/IfcOpenShell/IfcOpenShell/blob/v0.7.0/.github/workflows/ci.yml#L44

@skinkie
Copy link
Author

skinkie commented Jul 25, 2022

This still gives me deprecation warnings. (This was due to the missing Standard_Version.hxx)

@skinkie
Copy link
Author

skinkie commented Jul 25, 2022

Uncovered a bug in the existing code while fixing this :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants