Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCC_VERSION_HEX is included in files which do not include Standard_Version.hxx #2313

Closed
skinkie opened this issue Jul 25, 2022 · 3 comments
Closed

Comments

@skinkie
Copy link

skinkie commented Jul 25, 2022

The following files contain references to OCC_VERSION_HEX without including Standard_Version.hxx. I have noticed in #2312 this uncovered a bug. Should the include be added?

https://github.com/IfcOpenShell/IfcOpenShell/blob/v0.7.0/src/ifcgeom_schema_agnostic/boolean_utils.cpp
https://github.com/IfcOpenShell/IfcOpenShell/blob/v0.7.0/src/ifcgeom/IfcGeom.h

@aothms
Copy link
Member

aothms commented Jul 25, 2022

Yes please :)

@dirkolbrich
Copy link
Contributor

Can be closed due to commit 4cd0932?

@aothms
Copy link
Member

aothms commented Sep 1, 2023

Just double checked, should be ok, thanks :)

$ grep -Rc OCC_VERSION_HEX . | grep -v :0$
./examples/IfcAdvancedHouse.cpp:1
./examples/IfcOpenHouse.cpp:1
./ifcconvert/IfcConvert.cpp:4
./ifcgeom/IfcBooleanResult.cpp:1
./ifcgeom/IfcBSplineSurfaceWithKnots.cpp:1
./ifcgeom/IfcGeom.cpp:3
./ifcgeom/IfcPlane.cpp:1
./ifcgeom/IfcRectangularPyramid.cpp:1
./ifcgeom/IfcTrimmedCurve.cpp:2
./ifcgeom_schema_agnostic/boolean_utils.cpp:7
./ifcgeom_schema_agnostic/layerset.cpp:2
./ifcgeom_schema_agnostic/wire_utils.cpp:1
./serializers/SvgSerializer.cpp:2
./serializers/SvgSerializer.h:2

$ grep -Rc Standard_Version . | grep -v :0$
./examples/IfcAdvancedHouse.cpp:1
./examples/IfcOpenHouse.cpp:1
./ifcconvert/IfcConvert.cpp:1
./ifcgeom/IfcBooleanResult.cpp:1
./ifcgeom/IfcBSplineSurfaceWithKnots.cpp:1
./ifcgeom/IfcGeom.cpp:1
./ifcgeom/IfcPlane.cpp:1
./ifcgeom/IfcRectangularPyramid.cpp:1
./ifcgeom/IfcTrimmedCurve.cpp:1
./ifcgeom_schema_agnostic/boolean_utils.cpp:1
./ifcgeom_schema_agnostic/layerset.cpp:1
./ifcgeom_schema_agnostic/wire_utils.cpp:1
./serializers/OpenCascadeBasedSerializer.cpp:1
./serializers/SvgSerializer.cpp:1
./serializers/SvgSerializer.h:1

@aothms aothms closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants