Skip to content

Add tests for session_registry #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 14, 2025
Merged

Conversation

madhav165
Copy link
Collaborator

@madhav165 madhav165 commented Jul 14, 2025

🐛 Bug-fix PR


📌 Summary

Added some test cases for session_registry.py. Improves coverage from 58% to 67%.

🧪 Verification

Check Command Status
Lint suite make lint pass
Unit tests make test pass

📐 MCP Compliance (if relevant)

  • Matches current MCP spec
  • No breaking change to MCP clients

✅ Checklist

  • Code formatted (make black isort pre-commit)
  • No secrets/credentials committed

madhav165 added 14 commits July 9, 2025 18:35
Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>
Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>
Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>
Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>expected_msg_json
Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>
Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>
Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>
Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>expected_msg_json
Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>
Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>
Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>
Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>expected_msg_json
@madhav165 madhav165 self-assigned this Jul 14, 2025
@madhav165 madhav165 marked this pull request as draft July 14, 2025 17:04
Signed-off-by: Madhav Kandukuri <madhav165@gmail.com>
@madhav165 madhav165 marked this pull request as ready for review July 14, 2025 17:30
Copy link
Member

@crivetimihai crivetimihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@crivetimihai crivetimihai merged commit 031342e into main Jul 14, 2025
21 checks passed
@crivetimihai crivetimihai deleted the improve-test-case-coverage branch July 14, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants