-
Notifications
You must be signed in to change notification settings - Fork 147
gateway_servers_actions_view #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @TS0713 - the code changed quite a bit since the PR got started, could you please rebase & retest the changes, and rename the PR? Thanks! |
Passes
Fails:
|
Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Rakhi Dutta <rakhibiswas@yahoo.com> Signed-off-by: Satya <tsp.0713@gmail.com>
Signed-off-by: Satya <tsp.0713@gmail.com>
d19e160
to
2b335e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TS0713 Tested the PR
- View Gateway working in Inactive and Offline states
- Status in View Gateway popup not changing with Gateway status - always showing Inactive.
Please check status in popup.
@madhav165 Status in gateway popup is working fine. Just tested it. Could you please check in incognito once or try clearing cache. |
@kevalmahajan Yes, looks like a browser cache issue. Looks fine. @crivetimihai Looks good. |
Thanks, will fix the whitespace issue and merge. |
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Ran: Tested with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works locally, merging after github actions targets run.
🐛 Bug-fix PR
📌 Summary
__version__
instead of hardcoded values💡 Fix Description
🧪 Verification
make test
make black
make lint-web
📐 MCP Compliance (if relevant)
✅ Checklist
make black isort pre-commit
)Signed-off-by: Satya tsp.0713@gmail.com