Switch to using the official ibmcloud-cli action #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Frey <fryguy9@gmail.com>
|
Thanks for the PR, will need to check if the org has this on the allow list, will test soon! |
|
It's from the IBM org, and yes it's on the allow list. |
|
The failing test is because I made this PR from a fork. We can probably gate that one step in that action to not run on forks, but in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Feature / Enhancement PR
🔗 Epic / Issue
Link to the epic or parent issue:
N/A
🚀 Summary (1-2 sentences)
What does this PR add or change?
Since we have an official GitHub action for the IBM Cloud CLI, this switches the GitHub Action to use it.
🧪 Checks
make lintpassesmake testpasses📓 Notes (optional)
Design sketch, screenshots, or extra context.
If the change introduces or alters an architectural decision, add or update an ADR in
docs/docs/adr/and link it here._N/A