Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Extract symlinks on macOS #702

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[FIX] Extract symlinks on macOS #702

wants to merge 3 commits into from

Conversation

flavioislima
Copy link
Contributor

Testing different approaches to this issue.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima mentioned this pull request Jan 12, 2024
Open
4 tasks
@BrettCleary
Copy link
Collaborator

making a note to bump the hyperplay package.json version to 0.10.1 on this PR @flavioislima

@flavioislima
Copy link
Contributor Author

@awantoch can you test the problematic game build with the app build from this PR?
Or let me know once it is available so I can try :)

@awantoch
Copy link

So far my current behavior is that the install visually succeeds, but fails to launch.

Upon inspecting my game folder, I see the Race.app.zip is still in its compressed state, so it appears that the extraction did not succeed, hopefully it's something simple.

Here's my logs as well:

(16:09:57) INFO:    [Backend]:          Creating abort controller for legendary-version
(16:09:57) INFO:    [Legendary]:        Running command: XDG_CONFIG_HOME="/Users/alec/Library/Application Support/hyperplay/legendaryConfig" /Users/alec/Workspace/hyperplay-desktop-client/public/bin/darwin/legendary --version
(16:09:57) INFO:    [Legendary]:        Legendary location: /Users/alec/Workspace/hyperplay-desktop-client/public/bin/darwin/legendary
(16:09:57) INFO:    [Gog]:              GOGDL location: /Users/alec/Workspace/hyperplay-desktop-client/public/bin/darwin/gogdl
(16:09:57) INFO:    [Backend]:          Loading MetaMask extension
(16:09:57) INFO:    [Connection]:       Connectivity: check-online
(16:09:57) INFO:    [Connection]:       Pinging external endpoints
(16:09:57) INFO:    [Backend]:          Creating abort controller for legendary-version
(16:09:57) INFO:    [Legendary]:        Running command: XDG_CONFIG_HOME="/Users/alec/Library/Application Support/hyperplay/legendaryConfig" /Users/alec/Workspace/hyperplay-desktop-client/public/bin/darwin/legendary --version
(16:09:57) INFO:    [Legendary]:        Legendary location: /Users/alec/Workspace/hyperplay-desktop-client/public/bin/darwin/legendary
(16:09:57) INFO:    [Gog]:              GOGDL location: /Users/alec/Workspace/hyperplay-desktop-client/public/bin/darwin/gogdl
(16:09:57) INFO:    [Gog]:              GOGDL location: /Users/alec/Workspace/hyperplay-desktop-client/public/bin/darwin/gogdl
(16:09:57) INFO:    [Backend]:          MetaMask extension loaded
(16:09:57) INFO:    [Backend]:          LaunchDarkly client initialized
(16:09:57) INFO:    [Backend]:          Registered protocol with OS.
(16:09:57) INFO:    [Backend]:          App is starting in headless mode = undefined isCLINoGui = false startInTray = undefined
(16:09:57) INFO:    [Connection]:       Connectivity: online
(16:09:57) INFO:    [Backend]:          User Not Found, removing it from Store
(16:09:57) ERROR:   [Gog]:              Unable to syncQueued playtime, userData not present
(16:09:59) INFO:    [Backend]:          Frontend Ready
(16:09:59) INFO:    [Backend]:          Loading Screen Ready
(16:09:59) INFO:    [Frontend]:         Refreshing hyperplay Library
(16:10:00) INFO:    [GlobalConfig]:     Searching for Gaming Porting Toolkit Wine
(16:10:00) WARNING: [Backend]:          listUpdateableGames not implemented on Sideload Library Manager
(16:10:00) INFO:    [Gog]:              Found 0 game(s) to update
(16:10:00) WARNING: [Backend]:          listUpdateableGames not implemented on Sideload Library Manager
(16:10:00) INFO:    [Gog]:              Found 0 game(s) to update
(16:10:00) WARNING: [Backend]:          listUpdateableGames not implemented on Sideload Library Manager
(16:10:00) INFO:    [Gog]:              Found 0 game(s) to update
(16:10:02) INFO:    [Backend]:          Deleting abort controller for legendary-version
(16:10:02) INFO:    [Backend]:          Deleting abort controller for legendary-version
(16:10:02) INFO:    [Backend]:          Creating abort controller for gogdl-version
(16:10:02) INFO:    [Gog]:              Running command: /Users/alec/Workspace/hyperplay-desktop-client/public/bin/darwin/gogdl --auth-config-path "/Users/alec/Library/Application Support/hyperplay/gog_store/auth.json" --version
(16:10:02) INFO:    [Backend]:          Creating abort controller for gogdl-version
(16:10:02) INFO:    [Gog]:              Running command: /Users/alec/Workspace/hyperplay-desktop-client/public/bin/darwin/gogdl --auth-config-path "/Users/alec/Library/Application Support/hyperplay/gog_store/auth.json" --version
(16:10:04) INFO:    [Backend]:          Starting the Download Queue
(16:10:06) INFO:    [Backend]:          Deleting abort controller for gogdl-version
(16:10:06) INFO:    [Backend]:          Deleting abort controller for gogdl-version
(16:10:06) INFO:    [Backend]:          Creating abort controller for nile-version
(16:10:06) INFO:    [Nile]:             Running command: XDG_CONFIG_HOME="/Users/alec/Library/Application Support/hyperplay/nile_config" /Users/alec/Workspace/hyperplay-desktop-client/public/bin/darwin/nile --version
(16:10:06) INFO:    [Backend]:          Creating abort controller for nile-version
(16:10:06) INFO:    [Nile]:             Running command: XDG_CONFIG_HOME="/Users/alec/Library/Application Support/hyperplay/nile_config" /Users/alec/Workspace/hyperplay-desktop-client/public/bin/darwin/nile --version
(16:10:13) INFO:    [Backend]:          Deleting abort controller for nile-version
(16:10:13) INFO:    [Backend]:          Deleting abort controller for nile-version
(16:10:13) INFO:    [Backend]:          

HyperPlay Version: 0.10.0
Legendary Version:  0.20.32 Dark Energy (hotfix #6)
GOGdl Version: 0.7.3
Nile Version: 1.0.0 Jonathan Joestar

OS: macOS Sonoma 14.2.1 KERNEL: 23.2.0 ARCH: arm64
CPU: Apple M1 Pro @2.4 
RAM: Total: 32 GiB Available: 21.82 GiB
GRAPHICS: GPU0: Apple M1 Pro   


(16:10:13) INFO:    [Backend]:          

HyperPlay Version: 0.10.0
Legendary Version:  0.20.32 Dark Energy (hotfix #6)
GOGdl Version: 0.7.3
Nile Version: 1.0.0 Jonathan Joestar

OS: macOS Sonoma 14.2.1 KERNEL: 23.2.0 ARCH: arm64
CPU: Apple M1 Pro @2.4 
RAM: Total: 32 GiB Available: 21.82 GiB
GRAPHICS: GPU0: Apple M1 Pro   


(16:10:51) INFO:    [HyperPlay]:        Removing folder in uninstall: /Users/alec/Games/HyperPlay/mcverse/mcverseracing
(16:10:52) INFO:    [HyperPlay]:        Removing prefix /Users/alec/.wine
(16:10:52) INFO:    [Frontend]:         Refreshing hyperplay Library
(16:10:53) WARNING: [Backend]:          listUpdateableGames not implemented on Sideload Library Manager
(16:10:53) INFO:    [Gog]:              Found 0 game(s) to update
(16:10:55) INFO:    [HyperPlay]:        Getting install info for MCVERSE Racing
(16:10:55) INFO:    [HyperPlay]:        Getting install info for MCVERSE Racing
(16:10:57) INFO:    [HyperPlay]:        Getting install info for MCVERSE Racing
(16:10:57) INFO:    [DownloadManager]:  MCVERSE Racing  was added to the download queue.
(16:10:57) INFO:    [HyperPlay]:        Installing MCVERSE Racing to /Users/alec/Games/HyperPlay...
(16:10:57) INFO:    [HyperPlay]:        Downloading zip file to directory /Users/alec/Library/Application Support/hyperplay/.temp/0xddb2462fc071433dc438c97306587ac3d412bdc38e3a971a84b9ce4f14ffe9a7 filename 0.1.7.zip
(16:10:57) INFO:    [HyperPlay]:        Downloading from https://gateway.valist.io/ipfs/bafybeih4wpe5o2uioog45yblcpu2qg27jnjsgzqlffpobqzcz35k5jxqjq/darwin_amd64/0.1.7.zip?token=RqmAAbgwzio1QfLFt4gfELfNiL_4Q59B-E3GmNjTtOE&expires=1705615852
(16:10:57) INFO:    [Backend]:          Creating abort controller for 0xddb2462fc071433dc438c97306587ac3d412bdc38e3a971a84b9ce4f14ffe9a7
(16:10:57) INFO:    [Backend]:          Preventing machine to sleep
(16:10:58) INFO:    [Backend]:          Started downloading 0.1.7.zip
(16:10:58) INFO:    [HyperPlay]:        Downloaded: 7.56 MB / 1.05 GB  @6.34 MB/s (0.70%)
(16:10:59) INFO:    [HyperPlay]:        Downloaded: 32.31 MB / 1.05 GB  @24.65 MB/s (2.99%)
(16:11:00) INFO:    [HyperPlay]:        Downloaded: 55.89 MB / 1.05 GB  @23.34 MB/s (5.17%)
(16:11:01) INFO:    [HyperPlay]:        Downloaded: 78.37 MB / 1.05 GB  @22.46 MB/s (7.26%)
(16:11:02) INFO:    [HyperPlay]:        Downloaded: 99.36 MB / 1.05 GB  @20.86 MB/s (9.20%)
(16:11:03) INFO:    [HyperPlay]:        Downloaded: 118.01 MB / 1.05 GB  @18.51 MB/s (10.93%)
(16:11:04) INFO:    [HyperPlay]:        Downloaded: 135.44 MB / 1.05 GB  @17.28 MB/s (12.54%)
(16:11:05) INFO:    [HyperPlay]:        Downloaded: 150.06 MB / 1.05 GB  @14.51 MB/s (13.89%)
(16:11:06) INFO:    [HyperPlay]:        Downloaded: 166.12 MB / 1.05 GB  @16 MB/s (15.38%)
(16:11:07) INFO:    [HyperPlay]:        Downloaded: 179.26 MB / 1.05 GB  @13.02 MB/s (16.60%)
(16:11:08) INFO:    [HyperPlay]:        Downloaded: 189.62 MB / 1.05 GB  @10.32 MB/s (17.56%)
(16:11:09) INFO:    [HyperPlay]:        Downloaded: 205.12 MB / 1.05 GB  @15.44 MB/s (18.99%)
(16:11:10) INFO:    [HyperPlay]:        Downloaded: 220.01 MB / 1.05 GB  @14.79 MB/s (20.37%)
(16:11:11) INFO:    [HyperPlay]:        Downloaded: 234.59 MB / 1.05 GB  @14.46 MB/s (21.72%)
(16:11:12) INFO:    [HyperPlay]:        Downloaded: 247.19 MB / 1.05 GB  @12.48 MB/s (22.89%)
(16:11:13) INFO:    [HyperPlay]:        Downloaded: 267.12 MB / 1.05 GB  @19.86 MB/s (24.73%)
(16:11:14) INFO:    [HyperPlay]:        Downloaded: 304.9 MB / 1.05 GB  @37.37 MB/s (28.23%)
(16:11:15) INFO:    [HyperPlay]:        Downloaded: 356.87 MB / 1.05 GB  @51.61 MB/s (33.04%)
(16:11:16) INFO:    [HyperPlay]:        Downloaded: 413.65 MB / 1.05 GB  @56.22 MB/s (38.30%)
(16:11:17) INFO:    [HyperPlay]:        Downloaded: 469.17 MB / 1.05 GB  @55.02 MB/s (43.44%)
(16:11:18) INFO:    [HyperPlay]:        Downloaded: 520.31 MB / 1.05 GB  @50.63 MB/s (48.17%)
(16:11:19) INFO:    [HyperPlay]:        Downloaded: 580.37 MB / 1.05 GB  @59.82 MB/s (53.73%)
(16:11:21) INFO:    [HyperPlay]:        Downloaded: 633.61 MB / 1.05 GB  @52.71 MB/s (58.66%)
(16:11:22) INFO:    [HyperPlay]:        Downloaded: 686.95 MB / 1.05 GB  @52.92 MB/s (63.60%)
(16:11:23) INFO:    [HyperPlay]:        Downloaded: 734.97 MB / 1.05 GB  @47.78 MB/s (68.05%)
(16:11:24) INFO:    [HyperPlay]:        Downloaded: 795.2 MB / 1.05 GB  @59.7 MB/s (73.62%)
(16:11:25) INFO:    [HyperPlay]:        Downloaded: 855.44 MB / 1.05 GB  @59.82 MB/s (79.20%)
(16:11:26) INFO:    [HyperPlay]:        Downloaded: 911.76 MB / 1.05 GB  @55.77 MB/s (84.42%)
(16:11:27) INFO:    [HyperPlay]:        Downloaded: 977.54 MB / 1.05 GB  @65.39 MB/s (90.51%)
(16:11:28) INFO:    [HyperPlay]:        Downloaded: 1.01 GB / 1.05 GB  @57 MB/s (95.83%)
(16:11:28) INFO:    [Backend]:          Download completed 0.1.7.zip
(16:11:28) INFO:    [DownloadManager]:  0xddb2462fc071433dc438c97306587ac3d412bdc38e3a971a84b9ce4f14ffe9a7 added to download manager finished.
(16:11:28) INFO:    [DownloadManager]:  0xddb2462fc071433dc438c97306587ac3d412bdc38e3a971a84b9ce4f14ffe9a7 removed from download manager.
(16:11:28) INFO:    [Frontend]:         Refreshing hyperplay Library
(16:11:28) INFO:    [Backend]:          Extracting 0.1.7/ from /Users/alec/Library/Application Support/hyperplay/.temp/0xddb2462fc071433dc438c97306587ac3d412bdc38e3a971a84b9ce4f14ffe9a7/0.1.7.zip to /Users/alec/Games/HyperPlay/mcverse/mcverseracing with 2 entries
(16:11:28) INFO:    [Backend]:          Extracting 0.1.7/Race.app.zip from /Users/alec/Library/Application Support/hyperplay/.temp/0xddb2462fc071433dc438c97306587ac3d412bdc38e3a971a84b9ce4f14ffe9a7/0.1.7.zip to /Users/alec/Games/HyperPlay/mcverse/mcverseracing with 2 entries
(16:11:31) INFO:    [Backend]:          Launching MCVERSE Racing (0xddb2462fc071433dc438c97306587ac3d412bdc38e3a971a84b9ce4f14ffe9a7)
(16:11:31) INFO:    [Backend]:          Completing HyperPlay Quest
(16:11:31) INFO:    [Backend]:          Preventing display from sleep
(16:11:31) ERROR:   [Backend]:          Failed to complete summon task: Unauthorized
(16:11:31) INFO:    [Backend]:          launching native sideloaded or hyperplay store game: /Users/alec/Games/HyperPlay/mcverse/mcverseracing/0.1.7/Race.app 
(16:11:31) WARNING: [Backend]:          File not executable, changing permissions temporarilly
(16:11:31) INFO:    [Backend]:          Creating abort controller for 0xddb2462fc071433dc438c97306587ac3d412bdc38e3a971a84b9ce4f14ffe9a7
(16:11:31) INFO:    [Backend]:          Backend: LD_PRELOAD= /Users/alec/Games/HyperPlay/mcverse/mcverseracing/0.1.7/Users/alec/Games/HyperPlay/mcverse/mcverseracing/0.1.7/Race.app
(16:11:31) DEBUG:   [Backend]:          Logging to file "/Users/alec/Library/Application Support/hyperplay/GamesConfig/0xddb2462fc071433dc438c97306587ac3d412bdc38e3a971a84b9ce4f14ffe9a7-lastPlay.log"
(16:11:31) ERROR:   [Backend]:          Error running command "LD_PRELOAD= /Users/alec/Games/HyperPlay/mcverse/mcverseracing/0.1.7/Users/alec/Games/HyperPlay/mcverse/mcverseracing/0.1.7/Race.app": Error: spawn /Users/alec/Games/HyperPlay/mcverse/mcverseracing/0.1.7/Race.app ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:284:19)
    at onErrorNT (node:internal/child_process:477:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
(16:11:31) INFO:    [Backend]:          Stopping Display Power Saver Blocker
(16:11:31) INFO:    [Frontend]:         Refreshing hyperplay Library
(16:11:39) WARNING: [Backend]:          listUpdateableGames not implemented on Sideload Library Manager
(16:11:39) INFO:    [Gog]:              Found 0 game(s) to update
(16:11:39) WARNING: [Backend]:          listUpdateableGames not implemented on Sideload Library Manager
(16:11:39) INFO:    [Gog]:              Found 0 game(s) to update
(16:12:03) INFO:    [GlobalConfig]:     Searching for Gaming Porting Toolkit Wine
(16:12:03) INFO:    [Backend]:          Creating abort controller for legendary-version
(16:12:03) INFO:    [Legendary]:        Running command: XDG_CONFIG_HOME="/Users/alec/Library/Application Support/hyperplay/legendaryConfig" /Users/alec/Workspace/hyperplay-desktop-client/public/bin/darwin/legendary --version
(16:12:03) INFO:    [Backend]:          Creating abort controller for gogdl-version
(16:12:03) INFO:    [Gog]:              Running command: /Users/alec/Workspace/hyperplay-desktop-client/public/bin/darwin/gogdl --auth-config-path "/Users/alec/Library/Application Support/hyperplay/gog_store/auth.json" --version
(16:12:03) INFO:    [GlobalConfig]:     Searching for Gaming Porting Toolkit Wine
(16:12:03) INFO:    [Backend]:          Creating abort controller for legendary-version
(16:12:03) INFO:    [Legendary]:        Running command: XDG_CONFIG_HOME="/Users/alec/Library/Application Support/hyperplay/legendaryConfig" /Users/alec/Workspace/hyperplay-desktop-client/public/bin/darwin/legendary --version
(16:12:03) INFO:    [Backend]:          Creating abort controller for gogdl-version
(16:12:03) INFO:    [Gog]:              Running command: /Users/alec/Workspace/hyperplay-desktop-client/public/bin/darwin/gogdl --auth-config-path "/Users/alec/Library/Application Support/hyperplay/gog_store/auth.json" --version
(16:12:07) INFO:    [Backend]:          Deleting abort controller for legendary-version
(16:12:07) INFO:    [Backend]:          Deleting abort controller for legendary-version
(16:12:07) INFO:    [Backend]:          Deleting abort controller for gogdl-version
(16:12:07) INFO:    [Backend]:          Deleting abort controller for gogdl-version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flavioislima @BrettCleary @awantoch