Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Preserve symlinks during extraction #536

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

BrettCleary
Copy link
Collaborator

@BrettCleary BrettCleary commented Sep 18, 2023

Recreates symlinks after a zip file is extracted

Testing

Test with synergy of serra native mac build latest main release

  • Synergy of Serra Genesis.app/Contents/Frameworks/Electron Framework.framework/* are all simlinks. You can verify with ls -l which will return lrwxrwxrwx in the first column. l is for "link"

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@BrettCleary BrettCleary added PR: Ready-For-Review PR is ready to be reviewed by peers PR: Ready-For-Test PR is ready to be tested by a QA and removed PR: WIP labels Sep 19, 2023
@BrettCleary BrettCleary removed PR: Ready-For-Review PR is ready to be reviewed by peers PR: Ready-For-Test PR is ready to be tested by a QA Priority: 2 - High labels Sep 19, 2023
@red-game-dev
Copy link
Contributor

Seems I'll need to apply these as soon as merged to my extraction PR, since that method no longer exists and we got a class instead ExtractZipService

@nyghtstalker
Copy link

nyghtstalker commented Jan 9, 2024

This is also occurring on MCVERSE with their MAC build (which is now disabled due to this issue).
https://hyperplay-workspace.slack.com/archives/C05RXC4S03A/p1704740561418779

Ticket for MCVERSE issue
#691

@awantoch
Copy link

awantoch commented Jan 9, 2024

next attempt: use the native system unzip tool

@flavioislima
Copy link
Contributor

Will do more testing on this other PR #702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extraction stuck when installing MCVERSE on MAC
5 participants