US likelihood #207
Open
US likelihood #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r US overall) and inclusion in likelihood. Also included option to multiply the likelihood of the total by a weight to provide it with more pressure on overall fits.
|
@jcblemai is this one ok to merge? seems you created a separate PR, not sure which is correct. |
|
I created two PR because there were two bases branch, and I don't know what is the difference.
so I wanted to have them visible (otherwise branch are forgotten when there is no PR open). Now @shauntruelove I cannot approve them but once these are reviewed (and conflict solved for the other one) they can be merged. |
|
Requested a review from alison and you here so we can merge this one at least |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added option for aggregation of sims and obs to total level (i.e., fo…r US overall) and inclusion in likelihood. Also included option to multiply the likelihood of the total by a weight to provide it with more pressure on overall fits.