Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Update) Commands #3788

Merged
merged 11 commits into from May 6, 2024
Merged

(Update) Commands #3788

merged 11 commits into from May 6, 2024

Conversation

HDVinnie
Copy link
Collaborator

@HDVinnie HDVinnie commented Apr 28, 2024

No description provided.

- Use DB facade instead of model fr performance.
- Wrap delete query in a database transaction to help against deadlocks with external tracker.
- Better documentation.
- Use DB facade instead of model fr performance.
- Wrap update query in a database transaction to help against deadlocks with external tracker.
- Better documentation.
- $userIds = Redis::command('LPOP', [$key, $userIdCount]); returned an array of strings so not sure how this worked. Wrapped in an array_map('intval', ).
- Use DB facade instead of model for performance.
- Wrap update query in a database transaction to help against deadlocks with external tracker.
- Better documentation.
- Use DB facade instead of model for performance.
- Better documentation.
Copy link

what-the-diff bot commented May 6, 2024

PR Summary

  • Environment (.env) configuration changes
    Some unnecessary code was removed from the .env.example file.

  • Updates to handle methods and Throwable classes usage
    A series of PHP files - most notably the AutoBanDisposableUsers.php, AutoCacheRandomMediaIds.php, AutoCacheUserLeechCounts.php,... down to the SyncTorrentSeasonEpisode, and TestMailSettings - went through changes to their handle methods and Throwable class usage.

  • File modification and removal
    Some PHP files (DbDumpTest, DbLoadTest, and VendorCleanupTest) were removed.

  • ConsoleTools Trait modifications
    Several methods within the ConsoleTools trait saw changes to the type hints for the $line parameter.

  • Changes in database configuration file
    The database configuration file (database.php), had the pristine-db-file config option removed.

The modifications to these PHP files will enhance the application's ability to manage specific processes and actions more efficiently and securely. Any unnecessary or outdated parts were removed or updated, thus improving the overall code quality and performance.

@HDVinnie HDVinnie marked this pull request as ready for review May 6, 2024 19:56
@HDVinnie HDVinnie merged commit 3b550fa into 8.x.x May 6, 2024
10 checks passed
@HDVinnie HDVinnie deleted the Commands branch May 6, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant