Implement ProjectileLaunchEvent #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhg023
reviewed
Jun 1, 2018
| ProjectileLaunchEvent launchEvent = EventFactory.getInstance() | ||
| .callEvent(new ProjectileLaunchEvent(projectile)); | ||
| if (launchEvent.isCancelled()) { | ||
| projectile.remove();; |
There was a problem hiding this comment.
Spotted that double semicolon ;)
|
I've rolled back the changes I originally intended to make only implementing the bare necessity for #922 . My original thought process was to make it so the entity didn't have to be added for the world (sending spawn entity packets to all players) only for it to be removed a tick later (sending destroy entity packets to all players), but this requires a bigger rewrite of some of the spawning code than I thought and therefore I think it is best suited for another PR. This is ready now though. |
Pr0methean
approved these changes
Jun 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the ProjectileLaunchEvent.