Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Event Coverage #922

Open
38 of 97 tasks
aramperes opened this issue May 24, 2018 · 9 comments
Open
38 of 97 tasks

API Event Coverage #922

aramperes opened this issue May 24, 2018 · 9 comments
Labels
Category: server feature good first issue hacktoberfest help wanted Priority: major Type: inconsistency Type: story

Comments

@aramperes
Copy link
Member

aramperes commented May 24, 2018 •
edited by mastercoms

Disclaimer for new contributors

Glowstone is an open-source project under the MIT license. In addition, we have a Contributors License Agreement which includes restrictions on the source of contributions (e.g. decompiled code from Mojang, Spigot, etc.). You will be asked to sign the CLA when submitting your first Pull Request.

Task

As suggested by creatorfromhell, this is a to-do list of API events that are not partially or fully implemented in Glowstone, including a direct link to their documentation.

Events are an important aspect of our coverage of the Bukkit, Spigot, and Paper APIs.

In bold are events whose feature is implemented, but missing the event firing.

Block Events

Command Events

Nothing here

Enchantment Events

Nothing here

Entity Events

Hanging Entity Events

Nothing here

Inventory Events

Player Events

Profile Events

Server Events

Vehicle Events

Weather Events

Nothing here

World Events

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@aramperes aramperes changed the title Unimplemented Events API Event Coverage May 25, 2018
aramperes pushed a commit that referenced this issue May 27, 2018
@VaiTon @aramperes
Implement ItemMergeEvent, ExpBottleEvent, CreeperPowerEvent (#925)
0f76fe2 
Related to #922
aramperes pushed a commit that referenced this issue Jun 1, 2018
@jhg023 @aramperes
Implement PlayerToggleFlightEvent (#931)
ea5a0d0 
Related to #922.
aramperes pushed a commit that referenced this issue Jun 1, 2018
@Mystiflow @aramperes
Implement PlayerEggThrowEvent (#932)
a51fa17 
Related to #922.
This was referenced Jun 1, 2018
Merged
Merged
aramperes pushed a commit that referenced this issue Jun 2, 2018
@jhg023 @aramperes
Implement PlayerSwapHandItemsEvent (#934)
5ea0b55 
Related to #922.
aramperes pushed a commit that referenced this issue Jun 2, 2018
@jhg023 @aramperes
Implement InventoryOpenEvent (#938)
5d7d256 
Related to #922.
aramperes pushed a commit that referenced this issue Jun 3, 2018
@jhg023 @aramperes
Implement VehicleEnterEvent (#939)
a40541d 
Related to #922.
aramperes added a commit that referenced this issue Jun 3, 2018
@aramperes
Implement ProfileWhitelistVerifyEvent.
4c7e8c0 
Related to #922.

* Fixed /whitelist remove <player> showing usage error even on success
@Mystiflow Mystiflow mentioned this issue Jun 4, 2018
Merged
mastercoms pushed a commit that referenced this issue Jun 5, 2018
@jhg023 @mastercoms
Fire EntityRemoveFromWorldEvent (fixes part of #922) (#941)
8058aa7
mastercoms pushed a commit that referenced this issue Jun 7, 2018
@jhg023 @mastercoms
Fire EntityTeleportEvent (fixes part of #922) (#944)
9554ea6
@Pr0methean Pr0methean mentioned this issue Jun 8, 2018
Merged
This was referenced Dec 1, 2018
Merged
Merged
@VaiTon
Copy link
Contributor

VaiTon commented Dec 16, 2018

EntityShootBowEvent is implemented here

VaiTon added a commit to VaiTon/Glowstone that referenced this issue Dec 17, 2018
@VaiTon
Implements ProjectileHitEvent (GlowstoneMC#922)
0fd2db6
VaiTon added a commit to VaiTon/Glowstone that referenced this issue Dec 17, 2018
@VaiTon
Implements BlockPhysicsEvent and make every implementation call super (…
506ad22 
…GlowstoneMC#922)
VaiTon added a commit to VaiTon/Glowstone that referenced this issue Dec 17, 2018
@VaiTon
Implements PlayerExpChangeEvent (GlowstoneMC#922)
facae66
VaiTon added a commit to VaiTon/Glowstone that referenced this issue Dec 17, 2018
@VaiTon
Implements BroadcastMessageEvent (GlowstoneMC#922)
761e468
VaiTon added a commit to VaiTon/Glowstone that referenced this issue Dec 17, 2018
@VaiTon
Implements VechicleCreateEvent and delegate its implementation to Glo…
12b9c7c 
…wVehicle (GlowstoneMC#922)
@heisluft
Copy link
Contributor

I implemented PlayerLocaleChangeEvent in #1011

@Red-Teapot Red-Teapot mentioned this issue Feb 3, 2019
Merged
Pr0methean pushed a commit that referenced this issue Feb 3, 2019
@Red-Teapot @Pr0methean
Implement BlockPistonExtendEvent (#1013)
55b43af 
* Implement BlockPistonExtendEvent firing (addresses #922)

* Fix code style
@Red-Teapot Red-Teapot mentioned this issue Feb 3, 2019
Merged
@heisluft heisluft mentioned this issue Feb 3, 2019
Open
@aramperes
Copy link
Member Author

@VaiTon I see that a few commits in your fork mentioned this issue. Do you plan on PR-ing these changes?

@jhg023
Copy link
Contributor

jhg023 commented Feb 9, 2019

All of the links to the respective event documentation seem to be dead 👻

@clabe45 clabe45 mentioned this issue Jun 12, 2019
Open
@SHADOWDANCH
Copy link
Contributor

SHADOWDANCH commented Jul 19, 2019 •
edited

BlockPistonRetractEvent is firing here
BroadcastMessageEvent is firing here
ProjectileHitEvent is firing here
PlayerExpChangeEvent is firing here
VehicleCreateEvent is firing here

@SHADOWDANCH
Copy link
Contributor

BlockPhysicsEvent is firing here

@aramperes
Copy link
Member Author

I updated the links to use the Paper 1.12 docs, so they should no longer be dead.

mastercoms pushed a commit that referenced this issue Aug 5, 2019
@clabe45 @mastercoms
Fire PlayerInitialSpawnEvent (#922) (#1051)
cdf3bb8 

* No longer fire PlayerInitialSpawnEvent in GlowPlayer

It will be fired in player-specific code in GlowEntity, instead.

* Fire PlayerInitialSpawnEvent in GlowEntity

This way, it is ordered correctly with other event calls.

* Fix setting events' world not affecting player
@Arthasasyan Arthasasyan mentioned this issue Oct 8, 2019
Merged
@JoelLau
Copy link

JoelLau commented Oct 9, 2019

I'm decent at Java, admire minecraft (have the game), but don't play much. Would anybody be willing to give me guide me as I make my first pull requests here ?

@VaiTon
Copy link
Contributor

VaiTon commented Jul 8, 2021

BeaconEffectEvent has been implemented in c4c59a7.

VaiTon added a commit to VaiTon/Glowstone that referenced this issue Jul 8, 2021
@VaiTon
feat: fire PlayerPickupExperienceEvent and make it cancellable.
0008f36 
Related to GlowstoneMC#922
@VaiTon VaiTon mentioned this issue Jul 8, 2021
Merged
VaiTon added a commit to VaiTon/Glowstone that referenced this issue Jul 8, 2021
@VaiTon
feat: fire PlayerPickupExperienceEvent and make it cancellable.
6f27177 
Related to GlowstoneMC#922
VaiTon added a commit to VaiTon/Glowstone that referenced this issue Jul 8, 2021
@VaiTon
feat: fire PlayerPickupExperienceEvent and make it cancellable.
9678b16 
Related to GlowstoneMC#922
smartboyathome pushed a commit that referenced this issue Jul 9, 2021
@VaiTon
feat: fire PlayerPickupExperienceEvent and make it cancellable. (#1113)
72b2e23 
Related to #922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: server feature good first issue hacktoberfest help wanted Priority: major Type: inconsistency Type: story
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@aramperes @VaiTon @jhg023 @JoelLau @heisluft @SHADOWDANCH