Begin work on updating to 1.19.3 #1142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oved all Linkstone stuff
…API, updated game ver strings
…ix pallettes, currently we hardcode the sent data so it only uses one pallette index.
…i.vg's order. This included sending the player's initial position twice
|
|
|
All of the stupid stuff I did is fixed, I just need to fix some tests that are failing and checkstyle it. |
|
Any news ? |
mastercoms
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The login process is fully working, including chunk encoding
I am not sure if this PR is suitable to merge in it's current state, as I made several opinionated changes that need to be rolled back (removed GitHub tasks, removed dependency on Linkstone, changed DSL from Kotlin to Groovy, removed all publishing info from gradle, removed the glowstone repo since it was down.) I also need to go over it with checkstyle.
Anyway, here's everything I've been working on the past few days