Implemented PigZapEvent #1015
Open
Implemented PigZapEvent #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pr0methean
reviewed
Feb 5, 2019
Pr0methean
reviewed
Feb 5, 2019
|
I'm going to hold off on this PR until after we make the spawning code less miserable. |
…ig-zap-event Merge upstream
the pig (compliant with vanilla behaviour)
Have you yet started working on / thinking about the rewrite? |
|
No plans at this moment, so feel free! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements PigZapEvent (#922).
It relies on a custom spawn method in GlowWorld. I am open to any suggestions on how to solve this, although I think that this Method will be needed for any system where an Entity has to be mutated before it is spawned (or the spawn is cancelled) via an Event other than Creature/Item/EntitySpawnEvent.