Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline comments for unused variables #89

Merged
merged 1 commit into from Mar 18, 2024
Merged

Conversation

trmid
Copy link
Member

@trmid trmid commented Mar 18, 2024

Improves code readability and intention. Example:

function foo(address) external;

vs.

function foo(address /* user */) external;

Copy link

linear bot commented Mar 18, 2024

GEN-1217 QA-237 [N-37]

Copy link

LCOV of commit 611404a during coverage #488

Summary coverage rate:
  lines......: 99.0% (202 of 204 lines)
  functions..: 100.0% (55 of 55 functions)
  branches...: no data found

Files changed coverage rate:
                              |Lines       |Functions  |Branches    
  Filename                    |Rate     Num|Rate    Num|Rate     Num
  ==================================================================
  src/PrizeVault.sol          |98.9%    174| 100%    44|    -      0

@trmid trmid merged commit 17db1af into main Mar 18, 2024
2 checks passed
@trmid trmid deleted the gen-1217-qa-237-n-37 branch March 18, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants