Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace double approval with OZ forceApprove #87

Merged
merged 1 commit into from Mar 18, 2024

Conversation

trmid
Copy link
Member

@trmid trmid commented Mar 15, 2024

forceApprove handles tokens that require approvals to be set to zero. This way, we can remove the double approval call and clean up the logic while keeping the same behaviour.

Copy link

linear bot commented Mar 15, 2024

Copy link

LCOV of commit 1b73128 during coverage #484

Summary coverage rate:
  lines......: 99.5% (201 of 202 lines)
  functions..: 100.0% (55 of 55 functions)
  branches...: no data found

Files changed coverage rate:
                              |Lines       |Functions  |Branches    
  Filename                    |Rate     Num|Rate    Num|Rate     Num
  ==================================================================
  src/PrizeVault.sol          |99.4%    172| 100%    44|    -      0

@trmid trmid merged commit cc7fb67 into main Mar 18, 2024
2 checks passed
@trmid trmid deleted the gen-1211-qa-237-l-11-qa-212-l-03 branch March 18, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants