Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flask upgrade #901

Merged
merged 9 commits into from May 6, 2024
Merged

flask upgrade #901

merged 9 commits into from May 6, 2024

Conversation

samathad2023
Copy link
Contributor

A note to PR reviewers: it may be helpful to review our
code review documentation
to know what to keep in mind while reviewing pull requests.

Description

This should include:

  • removed setuptools
  • updated flask ,marshmallow version and other dependencies needed to support the latest version
  • other dependency changes to support the project

Copy link
Contributor

@xlorepdarkhelm xlorepdarkhelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @samathad2023! 🎉

@ccostino ccostino merged commit 1e04ecc into main May 6, 2024
5 checks passed
@ccostino ccostino deleted the notify-api-869 branch May 6, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants