Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final checks and tests of the Flask upgrade PRs #953

Closed
3 tasks done
ccostino opened this issue May 1, 2024 · 2 comments
Closed
3 tasks done

Final checks and tests of the Flask upgrade PRs #953

ccostino opened this issue May 1, 2024 · 2 comments
Assignees
Labels
dependencies Pull requests that update a dependency file engineering

Comments

@ccostino
Copy link
Contributor

ccostino commented May 1, 2024

We have two open PRs for the Flask upgrades that have been worked on that are ready for full review and testing. We want to make sure everything is still functioning properly and no new errors are happening with all of the dependency upgrades.

We also want to get these PRs merged as they're a requirement to the SQLAlchemy upgrade PR that is also open.

Implementation Sketch and Acceptance Criteria

  • Pull down the branches in each of the PRs for the API and Admin to your local machine:
  • Run make bootstrap in both repos on your machine to make sure you get all of the dependency updates; there will be quite a few!
  • Run the API and Admin locally and work through the QA test template on the site to test all of the site features and functionality to make sure everything works and no new errors are showing up; if any do, document them in this ticket.

Security Considerations

  • Being able to update to the newest version of Flask lets us take advantage of new features and incorporate security enhancements and fixes.
  • This update lets us update a number of other dependencies as well.
@ccostino ccostino added engineering dependencies Pull requests that update a dependency file labels May 1, 2024
@anagradova
Copy link
Contributor

I updated the local code with make bootstrap for notifications-admin and notifications-api, completed the manual QA template, and clicked through every link. No errors were found.

@ccostino
Copy link
Contributor Author

ccostino commented May 6, 2024

The Flask updates have been merged and deployed to staging!

@ccostino ccostino closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file engineering
Projects
Status: Done
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants