Add font-display to eliminate Lighthouse warning #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robmadole
force-pushed
the
font-display-fix
branch
from
af442f5
to
5332c18
Compare
|
closes #108 |
mlwilkerson
force-pushed
the
font-display-fix
branch
from
5332c18
to
1cd6676
Compare
mlwilkerson
approved these changes
Mar 31, 2021
|
Thank you for fixing it that quickly! |
|
I intend to release this week, which would include this change. |
|
@mlwilkerson Thanks again! Looking forward to update it. |
This was referenced Oct 22, 2022
lubber-de
added a commit
to fomantic/create-fomantic-icons
that referenced
this pull request
Oct 24, 2022
the icon fonts need font-display to eliminate lighthouse warning in devtools Fontaweseome did this themselves by FortAwesome/wordpress-fontawesome#110 ## Related FUI PR fomantic/Fomantic-UI#2519
lubber-de
added a commit
to fomantic/Fomantic-UI
that referenced
this pull request
Oct 24, 2022
the icon fonts need font-display to eliminate lighthouse warning in devtools Fontaweseome did this themselves by FortAwesome/wordpress-fontawesome#110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref FortAwesome/Font-Awesome#16077