Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set font-display rule to block to make Lighthouse happy #108

Closed
oleksandrzaiats opened this issue Mar 20, 2021 · 3 comments
Closed

Set font-display rule to block to make Lighthouse happy #108

oleksandrzaiats opened this issue Mar 20, 2021 · 3 comments

Comments

@oleksandrzaiats
Copy link

Hi!
It seems that the issue (FortAwesome/Font-Awesome#16077 that seem to be fixed in the mail repo) still persists when using Font Awesome Wordpress plugin (https://wordpress.org/plugins/font-awesome/). I am using that plugin (with the latest version of font - 5.15.2) and I get Leverage the font-display CSS feature... in the report from Lighthouse. This warning displays fonts from urls like https://use.fontawesome.com/releases/v5.15.2/webfonts/fa-** as affected.
I checked the code of that plugin and it seems like there is no font-display set. I did not find any issue tracking for that plugin so I decided to write here.
Is it possible to fix that? Thanks!

@mlwilkerson
Copy link
Member

closed by #110

@mlwilkerson
Copy link
Member

@oleksandrzaiats this has been released in 4.0.0-rc22 (forgot to include it in the changelog!)

@oleksandrzaiats
Copy link
Author

oleksandrzaiats commented Apr 8, 2021

@mlwilkerson Thanks! I have updated the plugin and can confirm that the issue is solved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants