Skip to content
This repository has been archived by the owner on Nov 26, 2020. It is now read-only.

Feature: Two columns config. #343

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

wesleycgs
Copy link
Contributor

FolioReaderConfig.twoColumnsMode of type FolioReaderTwoColumnsMode.
Modes:

  • .disabled
    (Default value)
  • .alwaysEnabled
    Enabled in any situation, iPhone or iPad, portrait or landscape orientation.
  • .onlyLandscape
    Enabled in any device, only landscape orientation.
  • .onlyIpad
    Enabled only on iPad, portrait or landscape orientation.
  • .onlyIpadLandscape
    Enabled only on iPad, only landscape orientation.
  • .onlyIphone
    Enabled only on iPhone, portrait or landscape orientation.
  • .onlyIphoneLandscape
    Enabled only on iPhone, only landscape orientation.

iPad (Simulator)
two columns ipad simulator

iPhone (Real device)
two columns iphone

@wesleycgs wesleycgs changed the title Two columns configuration Feature: Two columns config. Jul 2, 2018
@hebertialmeida
Copy link
Member

Thanks for that, this is a huge improvement, many people have asked that before. I have tested and there are few things that I am not sure if you did notice.

  • While scrolling through the chapter the left space starts to decrease, that is probably some wrong margin calculation:
    bug-two-columns

  • The second one is when you will change the chapter, something is happening that makes the column scrolls:
    bug-2-two-columns

@wesleycgs
Copy link
Contributor Author

Wow, I did not really realize that. Thanks for the feedback.
I'll check this :)

@kosicki123
Copy link

kosicki123 commented Feb 22, 2019

Hi, thanks for this contribution, but have you ever finished this? I would love to use this update.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants