Skip to content
This repository has been archived by the owner on Nov 26, 2020. It is now read-only.

Migration/wkwebview #388

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Migration/wkwebview #388

wants to merge 7 commits into from

Conversation

OrbitalMan
Copy link

Here is my attempt to finish what @ricardohg started.
Known issues so far:

  • You have to select a text couple of times in order to have an ability to play the audio from it.
  • The play button from menu also doesn't work before you select the text and make it to show play popup.
  • The pages counter doesn't always calculate correctly.

@ThakarRajesh
Copy link

Hello @OrbitalMan
We have check this wkwebview last commit. FolioReaderCenter.swift this file still using webview. please check and update
line 1291 let cell = ((scrollView.superview as? UIWebView)?.delegate as? FolioReaderPage)
Thanks

OrbitalMan
OrbitalMan commented Jul 2, 2020
View reviewed changes
Source/FolioReaderCenter.swift
@@ -1281,7 +1272,7 @@ open class FolioReaderCenter: UIViewController, UICollectionViewDelegate, UIColl
// Perform the page after a short delay as the collection view hasn't completed it's transition if this method is called (the index paths aren't right during fast scrolls).
delay(0.2, closure: { [weak self] in
if (self?.readerConfig.scrollDirection == .horizontalWithVerticalContent),
let cell = ((scrollView.superview as? UIWebView)?.delegate as? FolioReaderPage) {
let cell = ((scrollView.superview as? WKWebView)?.navigationDelegate as? FolioReaderPage) {
let currentIndexPathRow = cell.pageNumber - 1
Copy link
Author

@OrbitalMan OrbitalMan Jul 2, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ThakarRajesh! I have already fixed the UIWebView reference - please take a look at commit 49076e4

@thilakks
Copy link

Hi,
When are you going to release WKWebview functionalities in FolioReader, we are waiting for it.

@startFromHere
Copy link

Hi,
Thanks for this pull request, Is there any solution of two columns config on WKWebview? like this feature:#343

@ThakarRajesh
Copy link

Hello @OrbitalMan
Type 'Bundle' has no member 'frameworkBundle' in FolioReaderScript.swift how to resolved this issue.

@hellbit
Copy link

hellbit commented Sep 29, 2020

Hey guys, who solved a problem with images? Right now WKWebView doesn't load images from epub.

@aleks990822
Copy link

Hello @OrbitalMan , after migration, I ran into a problem with fonts, they just stopped working, I have some strange font working, something from the system

@bluetechsky bluetechsky mentioned this pull request Nov 25, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@OrbitalMan @ThakarRajesh @thilakks @startFromHere @hellbit @aleks990822