Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

433 post sensor #767

Merged
merged 22 commits into from Aug 1, 2023
Merged

433 post sensor #767

merged 22 commits into from Aug 1, 2023

Conversation

GustaafL
Copy link
Contributor

Description

Adds POST endpoint to the Sensor API. This can be used to create new Sensors.

Look & Feel

Example post:

{
    "name": "power",
    "resolution": "PT1H",
    "unit": "kWh",
    "generic_asset_id": 1,
}

Related Items

#433

  • [x ] I agree to contribute to the project under Apache 2 License.
  • [ x] To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

GustaafL added 5 commits July 5, 2023 14:47
feat(sensors): adds fetch_one sensor endpoint to API
fa465c8 
Signed-off-by: GustaafL <guus@seita.nl>
feat(sensors): adds post sensor to API
415f861 
Signed-off-by: GustaafL <guus@seita.nl>
post sensor still needs work
4e3f6c1 
Signed-off-by: GustaafL <guus@seita.nl>
feat(sensor): adds post sensor
714b1a0 
Signed-off-by: GustaafL <guus@seita.nl>
docs(sensor): changes the docstring of the post function
058cb41 
Signed-off-by: GustaafL <guus@seita.nl>
@GustaafL GustaafL requested a review from nhoening July 20, 2023 09:11
@nhoening
clearer names for the arguments to permission_required_for_context de…
5691405 
…corator, especially arg_loader was misleading

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
one more renaming
ed53575 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
expanding possibilities in the require_permission_for_context decorat…
2376148 
…or, for when we only have an AuthModelMixin ID.

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Flix6x
Flix6x reviewed Jul 20, 2023
View reviewed changes
flexmeasures/data/schemas/times.py Outdated Show resolved Hide resolved
flexmeasures/data/schemas/times.py Outdated Show resolved Hide resolved
flexmeasures/data/schemas/times.py Outdated Show resolved Hide resolved
feat(sensor): post sensor without schema changes
957c144 
Signed-off-by: GustaafL <guus@seita.nl>
@nhoening nhoening added this to the 0.15.0 milestone Jul 24, 2023
GustaafL added 3 commits July 25, 2023 09:14
feat(sensor): adds patch sensor
3e37e08 
Signed-off-by: GustaafL <guus@seita.nl>
feat(sensor): users services change import back
8b3dee8 
Signed-off-by: GustaafL <guus@seita.nl>
docs(sensor): remove prints and update times docstrings
1e364ad 
Signed-off-by: GustaafL <guus@seita.nl>
@GustaafL GustaafL mentioned this pull request Jul 25, 2023
Open
GustaafL added 2 commits July 25, 2023 14:15
docs(sensor): update changelogs
e8d5c39 
Signed-off-by: GustaafL <guus@seita.nl>
docs(sensor): update change_log date
8f0a511 
Signed-off-by: GustaafL <guus@seita.nl>
nhoening
nhoening requested changes Jul 25, 2023
View reviewed changes
flexmeasures/api/v3_0/sensors.py Outdated Show resolved Hide resolved
flexmeasures/api/v3_0/tests/test_sensors_api.py Show resolved Hide resolved
documentation/api/change_log.rst Outdated Show resolved Hide resolved
flexmeasures/data/schemas/sensors.py Outdated Show resolved Hide resolved
flexmeasures/data/schemas/times.py Outdated Show resolved Hide resolved
GustaafL added 5 commits July 25, 2023 20:09
feat(sensor): changes to duration and event_resolution (untested)
a997dbe 
Signed-off-by: GustaafL <guus@seita.nl>
feat(cli): adds support for both int and iso duration string for sens…
3c467d4 
…or resulution

Signed-off-by: GustaafL <guus@seita.nl>
feat(sensor): changes times duration and sensor schema
9f87d30 
Signed-off-by: GustaafL <guus@seita.nl>
feat(sensor): tests for unauthorized
0402fbe 
Signed-off-by: GustaafL <guus@seita.nl>
feat(sensor): tests for unauthorized fetch one
e49a94f 
Signed-off-by: GustaafL <guus@seita.nl>
@GustaafL GustaafL requested a review from nhoening July 31, 2023 10:31
GustaafL and others added 2 commits July 31, 2023 16:13
nhoening
nhoening requested changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have basically only naming and documentation requests left.

flexmeasures/api/v3_0/tests/test_sensors_api.py Outdated Show resolved Hide resolved
flexmeasures/api/v3_0/tests/test_sensors_api.py Show resolved Hide resolved
flexmeasures/data/schemas/sensors.py Outdated Show resolved Hide resolved
flexmeasures/api/v3_0/sensors.py Outdated Show resolved Hide resolved
documentation/changelog.rst Outdated Show resolved Hide resolved
feat(sensor): adds docstrings, changes test function names, changelog…
af9915c 
… changes and removes commented code

Signed-off-by: GustaafL <guus@seita.nl>
@GustaafL GustaafL requested a review from nhoening August 1, 2023 08:15
nhoening
nhoening approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@nhoening nhoening merged commit d25deb2 into main Aug 1, 2023
4 checks passed
@nhoening nhoening deleted the 433-post-sensor branch August 1, 2023 08:19
@GustaafL GustaafL mentioned this pull request Aug 1, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flix6x Flix6x Flix6x left review comments

@nhoening nhoening nhoening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GustaafL @nhoening @Flix6x