Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sensor): removes resolution from fetch one response to only retur… #779

Merged
merged 2 commits into from Aug 1, 2023

Conversation

GustaafL
Copy link
Contributor

@GustaafL GustaafL commented Aug 1, 2023

Description

In PR #767 the fetch one sensor incorrectly returned resolution in the API response. This field would have the same value as event_resolution. The fetch one sensor endpoint now only returns the event_resolution

Look & Feel

Before:
{
"name": "some gas sensor",
"unit": "m³/h",
"entity_address": "ea1.2023-08.localhost:fm1.1",
"event_resolution": "PT10M",
"resolution": "PT10M",
"generic_asset_id": 4,
"timezone": "UTC",
}
After:

        {
            "name": "some gas sensor",
            "unit": "m³/h",
            "entity_address": "ea1.2023-08.localhost:fm1.1",
            "event_resolution": "PT10M",
            "generic_asset_id": 4,
            "timezone": "UTC",
        }
  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

GustaafL added 2 commits August 1, 2023 11:02
…n event_resolution

Signed-off-by: GustaafL <guus@seita.nl>
Signed-off-by: GustaafL <guus@seita.nl>
@GustaafL GustaafL requested a review from nhoening August 1, 2023 09:13
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

@GustaafL GustaafL marked this pull request as ready for review August 1, 2023 09:16
@nhoening nhoening merged commit 029e2a8 into main Aug 1, 2023
3 of 5 checks passed
@nhoening nhoening deleted the 433-post-sensor-merge-conflict-fix branch August 1, 2023 09:24
@Flix6x Flix6x added bug Something isn't working API labels Aug 1, 2023
@Flix6x Flix6x added this to the 0.15.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants