Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sort sensor legend in order of appearence #742

Merged
merged 5 commits into from Jun 23, 2023

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Jun 21, 2023

This PR makes it a lot easier to read off the color legend on the asset page, especially when showing many sensors, as they will now be ordered from top to bottom in the same order as they appear in the chart (as defined in the sensors_to_show attribute), rather than alphabetically.

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added this to the 0.15.0 milestone Jun 21, 2023
@Flix6x Flix6x self-assigned this Jun 21, 2023
Copy link
Contributor

@victorgarcia98 victorgarcia98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just a couple of minor things.

flexmeasures/data/models/charts/belief_charts.py Outdated Show resolved Hide resolved
flexmeasures/data/models/charts/belief_charts.py Outdated Show resolved Hide resolved
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x merged commit 769bddf into main Jun 23, 2023
5 of 7 checks passed
@Flix6x Flix6x deleted the feature/sort-sensor-legend-in-order-of-appearence branch June 23, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants