Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent mutating the original FIELD_DEFINITIONS dict #746

Merged
merged 4 commits into from Jun 26, 2023
Merged

fix: prevent mutating the original FIELD_DEFINITIONS dict #746

merged 4 commits into from Jun 26, 2023

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Jun 23, 2023

The event_start_field_definition kept the reference to the original data. In such case, we could encounter interference when multiple users are accessing.

Adapted from @victorgarcia98 in #742 (comment)

Again, great catch!

@Flix6x
fix: prevent mutating the original FIELD_DEFINITIONS dict
b8251a5 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added bug Something isn't working UI labels Jun 23, 2023
@Flix6x Flix6x added this to the 0.14.1 milestone Jun 23, 2023
@Flix6x Flix6x self-assigned this Jun 23, 2023
victorgarcia98
victorgarcia98 approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@victorgarcia98 victorgarcia98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! 😄

@Flix6x Flix6x merged commit 35bfc02 into main Jun 26, 2023
6 of 7 checks passed
@Flix6x Flix6x deleted the fix/mutating-chart-FIELD_DEFINITIONS branch June 26, 2023 07:43
Flix6x added a commit that referenced this pull request Jun 26, 2023
@Flix6x @victorgarcia98
Backport PR #746: fix: prevent mutating the original FIELD_DEFINITION…
fccc0e2 
…S dict (#746)

* fix: prevent mutating the original FIELD_DEFINITIONS dict

Signed-off-by: F.N. Claessen <felix@seita.nl>

* docs: changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

---------

Signed-off-by: F.N. Claessen <felix@seita.nl>
Co-authored-by: Victor <victor@seita.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorgarcia98 victorgarcia98 victorgarcia98 approved these changes

Assignees

@Flix6x Flix6x

Labels
bug Something isn't working UI
Projects
None yet
Milestone
0.14.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Flix6x @victorgarcia98