Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

637 data model visualization is broken #638

Merged
merged 8 commits into from Apr 17, 2023
Merged

637 data model visualization is broken #638

merged 8 commits into from Apr 17, 2023

Commits on Apr 13, 2023

  1. do not use a fallback viewer command, PIL makes good picks by itself … 

    …and doesn't allow passing in a command anymore

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Apr 13, 2023
    Copy the full SHA
    66a0d71 View commit details
    Browse the repository at this point in the history

  2. Better UX for missing necessary param (either --uml or --schema is re… 

    …quired)

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Apr 13, 2023
    Copy the full SHA
    71af44c View commit details
    Browse the repository at this point in the history

  3. switch to default choice being to show new data models, --deprecated … 

    …replaces the --dev option

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Apr 13, 2023
    Copy the full SHA
    90facf2 View commit details
    Browse the repository at this point in the history

  4. add changelog entry 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Apr 13, 2023
    Copy the full SHA
    9e1522d View commit details
    Browse the repository at this point in the history

  5. actually reference PR Id in changelog, not issue Id 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Apr 13, 2023
    Copy the full SHA
    4667186 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. adapt comment which still mentioned --dev 

    Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Apr 17, 2023
    Copy the full SHA
    6037ec7 View commit details
    Browse the repository at this point in the history

  2. no need to install dot from apt (is a dependency in the sqlalchemy_sc… 

    …hemadisplay library), rename a variable for readability

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
    @nhoening
    nhoening committed Apr 17, 2023
    Copy the full SHA
    9958ef5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into 637-data-model-visualization-is-broken

    @nhoening
    nhoening committed Apr 17, 2023
    Copy the full SHA
    0822dae View commit details
    Browse the repository at this point in the history