637 data model visualization is broken #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and doesn't allow passing in a command anymore Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…quired) Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…replaces the --dev option Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Pull Request Test Coverage Report for Build 4722440452
💛 - Coveralls |
There was a problem hiding this comment.
I didn't know this feature and I really like it 😄
I run it locally and I an error when I had to install the required packages:
sudo apt install python3-pydot python3-pydot-ng graphviz
Error:
E: Unable to locate package python3-pydot-ng
By just installing graphviz with apt, the command make show-data-model, run without problem. Maybe we should update line.
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…hemadisplay library), rename a variable for readability Signed-off-by: Nicolas Höning <nicolas@seita.nl>
|
I believe you're right and I confimed it locally, @victorgarcia98. It seems the pydot capability can be also installed by pip, and actually it does come as a dependency of the library anyway. |
victorgarcia98
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #637 check there for some investigation details.