New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bokeh dependency and obsolete UI views #476
Conversation
Pull Request Test Coverage Report for Build 2962650355
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start of removing things, we need to tackle this in more steps anyways, starting with the legacy data models.
I discovered that Coveralls is not showing you the source with changes (newly uncovered lines), unless you log in there (using your Github credentials).
Then, pages like https://coveralls.io/builds/51635571 become very useful to understand which parts of the code base are now uncovered.
@@ -138,37 +126,16 @@ | |||
.bindPopup(` | |||
<div class="leaflet-marker-popup"> | |||
<div class="row"> | |||
<div class="col-sm-12"> | |||
<div class="col-sm-9"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it sits now, the space isn't being used. The title uses 9 cols, and the button below uses 3.
It leads to a lot of empty space on the right side.
Was that the intention?
And what would it take to display the current state in text form, as we discussed, e.g. "Current state: X% (of ".
Of course, the latter could also be done in a new ticket. But if it's small, this can be a good place as we are now taking that feature away. I might volunteer.
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@Flix6x mentioned there is still documentation in place mentioning plots which need Bokeh support (latest state?). That should be removed. This ticket talks about removing tutorials needing Bokeh (this is about charts) and potentially moving to Altair for this useful feature. This is the tutorial in question.
|
For sure. We already fetch charts using dedicated API endpoints, so it should just be a matter of moving them from the dev API blueprint to the v3_0 API blueprint, and adjusting the documentation.
They would look different (better imo) indeed. I believe the endpoint for fetching a sensor chart would be a closer replacement of the endpoint for fetching a "latest power state" chart than the endpoint for fetching an asset chart. I think this PR should still get a changelog entry, and then it should be ready to be merged. |
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Closes #405.
There should be some follow-ups we could discuss, like increasing our test coverage, and deciding on what info tooltips on the dashboard map should contain (or just link directly to the asset page).