Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset page shows error due to loading obsolete plot #492

Closed
Flix6x opened this issue Aug 29, 2022 · 1 comment · Fixed by #493
Closed

Asset page shows error due to loading obsolete plot #492

Flix6x opened this issue Aug 29, 2022 · 1 comment · Fixed by #493
Assignees
Labels
bug Something isn't working UI

Comments

@Flix6x
Copy link
Contributor

Flix6x commented Aug 29, 2022

This issue is related to #476. Since the asset page no longer shows a bokeh plot of the latest state (instead, an altair plot of sensor data is shown), the latest state plot should no longer be loaded by the server. For some assets, the asset page may show the following error message: ValueError : "Lightness must be between 0 and 1.".

@Flix6x Flix6x added bug Something isn't working UI labels Aug 29, 2022
@Flix6x Flix6x self-assigned this Aug 29, 2022
@Flix6x
Copy link
Contributor Author

Flix6x commented Aug 29, 2022

I have only encountered the error when the asset's power sensor has no data yet.

Flix6x added a commit that referenced this issue Sep 5, 2022
Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x added a commit that referenced this issue Sep 5, 2022
Do not fail asset page if one of the shown sensors records instantaneous values.


* Do not resample data of sensors recording instantaneous values

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Use linear interpolation for instantaneous sensors

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix tooltip

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix case with only instantaneous sensors

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix changelog entry for PR #493 / Issue #492

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix changelog date format

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Add release date for 0.11.1

Signed-off-by: F.N. Claessen <felix@seita.nl>

Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x added a commit that referenced this issue Sep 5, 2022
…eous values (#491)

Do not fail asset page if one of the shown sensors records instantaneous values.

* Do not resample data of sensors recording instantaneous values

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Use linear interpolation for instantaneous sensors

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix tooltip

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix case with only instantaneous sensors

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix changelog entry for PR #493 / Issue #492

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix changelog date format

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Add release date for 0.11.1

Signed-off-by: F.N. Claessen <felix@seita.nl>

Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant