Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable the GC, ML and Megalith to damage buildings by walking over them #6135

Merged
merged 7 commits into from May 1, 2024
Merged

Reenable the GC, ML and Megalith to damage buildings by walking over them #6135

merged 7 commits into from May 1, 2024

Conversation

Basilisk3
Copy link
Contributor

@Basilisk3 Basilisk3 commented Apr 27, 2024 •
edited

Description of the proposed changes

Reverts #5924.

Checklist

  • Changes are documented in the changelog for the next game version

@Basilisk3 Basilisk3 marked this pull request as draft April 27, 2024 19:21
@Basilisk3
Copy link
Contributor Author

This line in Unit.lua determines when the error that the previous PR fixed, is displayed.

https://github.com/FAForever/fa/blob/238efbcd9089139043d842062cb55729939c9cf7/lua/sim/Unit.lua#L3730C1-L3735C16

@Basilisk3 Basilisk3 marked this pull request as ready for review April 27, 2024 20:00
@Basilisk3 Basilisk3 mentioned this pull request Apr 27, 2024
Open
@Garanas Garanas merged commit 03ef54b into FAForever:deploy/fafdevelop May 1, 2024
5 checks passed
@Basilisk3 Basilisk3 deleted the T4Footfall branch May 1, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Basilisk3 @Garanas