Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Markdown In Bangla Books List #6621

Merged
merged 5 commits into from Nov 21, 2021
Merged

Fixed Markdown In Bangla Books List #6621

merged 5 commits into from Nov 21, 2021

Conversation

HridoyHazard
Copy link
Contributor

@HridoyHazard HridoyHazard commented Nov 19, 2021 •
edited

What does this PR do?

Add resource(s) | Remove resource(s) | Add info | Improve repo

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@HridoyHazard HridoyHazard mentioned this pull request Nov 19, 2021
Closed
@davorpa davorpa linked an issue Nov 19, 2021 that may be closed by this pull request
Bangla Books List Markdown Format Error #6620
Closed
@davorpa
Copy link
Member

davorpa commented Nov 19, 2021

Thanks for helping to address with #4579

@davorpa davorpa added the waiting for changes PR has been reviewed and changes/suggestions requested label Nov 19, 2021
@HridoyHazard
Copy link
Contributor Author

check now fixed according to your idea @davorpa

@davorpa davorpa self-requested a review November 19, 2021 23:41
davorpa
davorpa requested changes Nov 19, 2021
View reviewed changes
Copy link
Member

@davorpa davorpa left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not resolved yet

#6621 (comment)

@HridoyHazard @davorpa
Update books/free-programming-books-bn.md
e54b9d9 
Co-authored-by: David Ordás <3125580+davorpa@users.noreply.github.com>
@davorpa davorpa added 🚀 ready to merge LGTM. Waiting for final approval and removed waiting for changes PR has been reviewed and changes/suggestions requested labels Nov 20, 2021
@eshellman
Copy link
Collaborator

Thanks, and welcome to free-programming-books!

@eshellman eshellman merged commit b798ace into EbookFoundation:main Nov 21, 2021
@davorpa davorpa mentioned this pull request Nov 21, 2021
Merged
4 tasks
davorpa added a commit to davorpa/free-programming-books that referenced this pull request Nov 27, 2021
@davorpa
Merge EbookFoundation#6621 upstream/main commit into 6591/split-bangl…
c01131a 
…a-books-courses

Use ours to solve conflicts with: b798ace
@HridoyHazard HridoyHazard deleted the newb branch October 2, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davorpa davorpa davorpa approved these changes

Assignees

@HridoyHazard HridoyHazard

Labels
🚀 ready to merge LGTM. Waiting for final approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bangla Books List Markdown Format Error
3 participants
@HridoyHazard @davorpa @eshellman