Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(books-bn): split bangla books - courses #6626

Merged

Conversation

davorpa
Copy link
Member

@davorpa davorpa commented Nov 20, 2021

What does this PR do?

Add info | Improve repo

Splits free-programming-books-bn.md into two files, moving to free-courses-bn.md the YouTube videos.

Moreover, some minor reorganizations was made to address with consistency of listings (#4579):

  • books::(Android) ▶️ courses::(Android)
  • books::(Bootstrap) ▶️🔃 courses::(HTML and CSS :: Bootstrap)
  • books::(C) ✂️ courses::(C)
  • books::(C++) ▶️ courses::(C++)
  • books::(C Sharp) ▶️🔃 courses::(C#)
  • books::(Competitive Programming) 🔃 books::(Algorithms)
  • books:(CSS) ▶️🔃 courses::(HTML and CSS)
  • books:(Dart, Flutter, Git, Go) ▶️ courses::(Dart, Flutter, Git, Go)
  • books::(HTML) ▶️🔃 courses::(HTML and CSS)
  • books::(Java, JavasScript) ✂️ courses::(Java, JavasScript)
  • books:(jQuery, NodeJS, ReactJS) ▶️🔃 courses::(JavasScript :: jQuery, JavasScript :: Node.js, JavasScript :: React)
  • books::(Kotlin, MySQL, PHP, Svelte, TypeScript) ▶️ courses::(Kotlin, MySQL, PHP, Svelte, TypeScript)
  • books::(Python) ✂️ courses::(Python)
  • books::(OOP) ▶️🔃 courses::(Programming Paradigms)
  • books::(Visual Studio Code) ▶️🔃 courses::(IDE and editors)

Why is this valuable (or not)?

Implements #6591, Resolves #6591

Checklist:

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@davorpa davorpa self-assigned this Nov 20, 2021
99:1-100:121  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint
@davorpa davorpa changed the title chore(free-programming-books-bn): split bangla books - courses chore(books-bn): split bangla books - courses Nov 20, 2021
@davorpa davorpa added the conflicts Conflict(s) need to be resolved label Nov 21, 2021
@davorpa
Copy link
Member Author

davorpa commented Nov 21, 2021

Conflicts with #6621

@davorpa davorpa marked this pull request as ready for review November 21, 2021 16:15
@davorpa davorpa removed the conflicts Conflict(s) need to be resolved label Nov 27, 2021
@davorpa davorpa requested a review from a team November 27, 2021 17:24
@eshellman
Copy link
Collaborator

what do the "waiting to add in" comments mean?

@davorpa
Copy link
Member Author

davorpa commented Nov 28, 2021

what do the "waiting to add in" comments mean?

C, C++ C#, produces the same non-meaningful hash more or less: c, c_1, c_2. So

It's for having the section defined with the "special alias" but not rendered. Therefore if someone add resources, not is necessary to be worried about homogenize with the listings in other languages.

Let me know if removing sections is preferred

@eshellman
Copy link
Collaborator

Could you put it in markdown comments? The students I'm working with are parsing the markdown lists into JSON files, and markdown comments should be safer.

Hack using link references syntax

[//]: # (whatever you want)

[//]: # (
  whatever you want
  multiline
)
@davorpa
Copy link
Member Author

davorpa commented Nov 29, 2021

Could you put it in markdown comments? The students I'm working with are parsing the markdown lists into JSON files, and markdown comments should be safer.

Done at 42f5750

There are not a special syntax for Markdown but can be simulated with a wide adopted hack using link references to be compatible with all engines.

[//]: # (whatever you want single line)
[//]: # (
  whatever multiline
  you
  want
)

Kramdown engine have extensions like:

{::comment}
whatever you want...
....
{:/comment}

but doesn't work in GitHub preview. In GitHub Pages with Jekyll yes.

Recomended wrap hacks by empty lines


In anyway... HTML tags should be stripped / escaped / converted to plain text in this parser

We need check the rest of files

@eshellman
Copy link
Collaborator

let's remove them and add notes to CONTRIBUTING instead

@davorpa
Copy link
Member Author

davorpa commented Nov 30, 2021

let's remove them and add notes to CONTRIBUTING instead

Markdown comments added in 42f5750 are now removed at 6d29234. Empty sections too

@LuigiImVector LuigiImVector added the 🚀 ready to merge LGTM. Waiting for final approval label Dec 27, 2021
@eshellman eshellman merged commit a3cb567 into EbookFoundation:main Dec 27, 2021
@EbookFoundation EbookFoundation locked as resolved and limited conversation to collaborators Dec 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀 ready to merge LGTM. Waiting for final approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bangla books list is mostly courses
3 participants