Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: If it's a JoinColumnMapping, use property access #6216

Merged

Conversation

KDederichs
Copy link
Contributor

Fixes #6215 by checking if it's a JoinColumnMapping

@KDederichs KDederichs force-pushed the fix/orm_array_access_deprecation branch from 842e21b to 6cae006 Compare March 20, 2024 18:17
@KDederichs
Copy link
Contributor Author

Don't know what's up with the Windows builds, they seem broken atm.

@KDederichs KDederichs changed the title fix: If it's a join column, use property access fix: If it's a JoinColumnMapping, use property access Mar 20, 2024
@KDederichs KDederichs force-pushed the fix/orm_array_access_deprecation branch from 6cae006 to a5ed4b9 Compare March 20, 2024 18:32
@javiereguiluz javiereguiluz added this to the 4.x milestone Apr 16, 2024
@javiereguiluz
Copy link
Collaborator

Kai, thanks for this bug fix and sorry it took so long to merge it.

@javiereguiluz javiereguiluz merged commit 5523f61 into EasyCorp:4.x Apr 16, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using ArrayAccess on Doctrine\ORM\Mapping\JoinColumnMapping is deprecated
2 participants