Skip to content

Commit

Permalink
bug #6216 fix: If it's a JoinColumnMapping, use property access (KDed…
Browse files Browse the repository at this point in the history
…erichs)

This PR was merged into the 4.x branch.

Discussion
----------

fix: If it's a JoinColumnMapping, use property access

Fixes #6215 by checking if it's a JoinColumnMapping

Commits
-------

a5ed4b9 fix: If it's a join column, use property access
  • Loading branch information
javiereguiluz committed Apr 16, 2024
2 parents 5182566 + a5ed4b9 commit 5523f61
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
10 changes: 8 additions & 2 deletions src/Field/Configurator/CommonPreConfigurator.php
Expand Up @@ -2,6 +2,7 @@

namespace EasyCorp\Bundle\EasyAdminBundle\Field\Configurator;

use Doctrine\ORM\Mapping\JoinColumnMapping;
use EasyCorp\Bundle\EasyAdminBundle\Config\Action;
use EasyCorp\Bundle\EasyAdminBundle\Config\Crud;
use EasyCorp\Bundle\EasyAdminBundle\Context\AdminContext;
Expand Down Expand Up @@ -198,11 +199,16 @@ private function buildRequiredOption(FieldDto $field, EntityDto $entityDto): boo
$associatedEntityMetadata = $this->entityFactory->getEntityMetadata($doctrinePropertyMetadata->get('targetEntity'));
foreach ($doctrinePropertyMetadata->get('joinColumns', []) as $joinColumn) {
if (true === $doctrinePropertyMetadata->get('isOwningSide', true)) {
if (false === ($joinColumn['nullable'] ?? true)) {
if ($joinColumn instanceof JoinColumnMapping) {
$isNullable = $joinColumn->nullable ?? true;
} else {
$isNullable = $joinColumn['nullable'] ?? true;
}
if (false === $isNullable) {
return true;
}
} else {
$propertyNameInAssociatedEntity = $joinColumn['referencedColumnName'];
$propertyNameInAssociatedEntity = $joinColumn instanceof JoinColumnMapping ? $joinColumn->referencedColumnName : $joinColumn['referencedColumnName'];
$associatedPropertyMetadata = $associatedEntityMetadata->fieldMappings[$propertyNameInAssociatedEntity] ?? [];
$isNullable = $associatedPropertyMetadata['nullable'] ?? true;

Expand Down
2 changes: 1 addition & 1 deletion src/Filter/Configurator/EntityConfigurator.php
Expand Up @@ -40,7 +40,7 @@ public function configure(FilterDto $filterDto, ?FieldDto $fieldDto, EntityDto $
$numberOfRequiredJoinColumns = \count(array_filter(
$doctrineMetadata->get('joinColumns'),
// Doctrine ORM 3.x changed the returned type from array to JoinColumnMapping
static fn (array|JoinColumnMapping $joinColumn): bool => false === ($joinColumn['nullable'] ?? false))
static fn (array|JoinColumnMapping $joinColumn): bool => false === (($joinColumn instanceof JoinColumnMapping ? $joinColumn->nullable ?? false : $joinColumn['nullable'] ?? false)))
);

$someJoinColumnsAreNullable = \count($doctrineMetadata->get('joinColumns')) !== $numberOfRequiredJoinColumns;
Expand Down

0 comments on commit 5523f61

Please sign in to comment.