[karma-chai-sinon] remove duplicate global variables

[iisaduan]

Found while fixing microsoft/TypeScript#58326. This PR removes the duplicate declarations in this package.

Sinon already contains export as namespace sinon, so declare global { var Sinon } was a duplicate declaration.

Related:
#69552
#69551

[typescript-bot]

@iisaduan Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• karma-chai-sinon — on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 10 days — please merge or say something if there's a problem, otherwise it will be closed!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69553,
  "author": "iisaduan",
  "headCommitOid": "c5171473e8e67cf460d0909f0fc164f213e4a275",
  "mergeBaseOid": "7e5afee6c44bae8a92e5c8ffe725b6ac097e1b96",
  "lastPushDate": "2024-05-08T19:56:59.000Z",
  "lastActivityDate": "2024-05-23T18:08:31.000Z",
  "mergeOfferDate": "2024-05-12T19:37:38.000Z",
  "mergeRequestDate": "2024-05-23T18:08:31.000Z",
  "mergeRequestUser": "iisaduan",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "karma-chai-sinon",
      "kind": "edit",
      "files": [
        {
          "path": "types/karma-chai-sinon/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/karma-chai-sinon/karma-chai-sinon-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "vasek17"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "Anonymous4078",
      "date": "2024-05-12T19:37:00.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2101324865,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @vasek17 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@iisaduan: Everything looks good here. I am ready to merge this PR (at c517147) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@vasek17: you can do this too.)

[typescript-bot]

Re-ping @iisaduan / @vasek17:

This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Jun 11th (in three weeks) if this doesn't happen.

(If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.)

[iisaduan]

Ready to merge