[bandagedbd__bdapi] remove duplicate global variables

[iisaduan]

Found while fixing microsoft/TypeScript#58326. This PR removes the duplicate declarations in this package.

lodash already has export as namespace _, makingdeclare global { const _: typeof _; } redundant

Related:
#69553
#69552

[typescript-bot]

@iisaduan Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• bandagedbd__bdapi — on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 10 days — please merge or say something if there's a problem, otherwise it will be closed!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69551,
  "author": "iisaduan",
  "headCommitOid": "bd9615b9a76713d40127d630cc9735593260cf5a",
  "mergeBaseOid": "7e5afee6c44bae8a92e5c8ffe725b6ac097e1b96",
  "lastPushDate": "2024-05-08T19:56:54.000Z",
  "lastActivityDate": "2024-05-23T18:08:46.000Z",
  "mergeOfferDate": "2024-05-12T19:37:21.000Z",
  "mergeRequestDate": "2024-05-23T18:08:46.000Z",
  "mergeRequestUser": "iisaduan",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "bandagedbd__bdapi",
      "kind": "edit",
      "files": [
        {
          "path": "types/bandagedbd__bdapi/bandagedbd__bdapi-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/bandagedbd__bdapi/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "Anonymous4078",
      "date": "2024-05-12T19:36:38.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2101324868,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @iisaduan — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

[typescript-bot]

@iisaduan: Everything looks good here. I am ready to merge this PR (at bd9615b) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

[typescript-bot]

Re-ping @iisaduan / @«anyone?»:

This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Jun 11th (in three weeks) if this doesn't happen.

(If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.)

[iisaduan]

Ready to merge